Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3410: Merged Switch click with TextViews in ProfileEditActivity #3409

Merged
merged 3 commits into from
Jul 5, 2021

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Jul 5, 2021

Explanation

Fix #3410: Merged Switch click with TextViews in ProfileEditActivity

Similar to #3191 , this PR also merged the textviews with switch to make the entire area clickable. So basically Switch + 2 Texts are clickable.

UI Before vs. After (no change)

Tests

Screenshot 2021-07-05 at 8 46 24 PM

Accessibility Output

Earlier the screen reader would first read the title, then subtext and then finally the switch, i.e. it took 3 steps.

Now it merges all of that into 1 single step:

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@rt4914 rt4914 changed the title Fix #3130: Merged Switch click with TextViews in ProfileEditActivity and AdministratorControlsActivity Fix #3130: Merged Switch click with TextViews in ProfileEditActivity Jul 5, 2021
@rt4914 rt4914 changed the title Fix #3130: Merged Switch click with TextViews in ProfileEditActivity Fix #3410: Merged Switch click with TextViews in ProfileEditActivity Jul 5, 2021
@rt4914 rt4914 requested a review from anandwana001 July 5, 2021 15:23
@anandwana001 anandwana001 assigned rt4914 and unassigned anandwana001 Jul 5, 2021
@rt4914 rt4914 assigned anandwana001 and unassigned rt4914 Jul 5, 2021
@anandwana001 anandwana001 assigned rt4914 and unassigned anandwana001 Jul 5, 2021
@rt4914 rt4914 assigned anandwana001 and unassigned rt4914 Jul 5, 2021
@anandwana001 anandwana001 merged commit fb84577 into develop Jul 5, 2021
@anandwana001 anandwana001 deleted the switch-merged-clickable branch July 5, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ProfileEdit toggle radio buttons by clicking on the complete item
2 participants