Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3130: Merged Switch click with TextViews in AdministratorControlsActivity #3412

Merged
merged 3 commits into from
Jul 5, 2021

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Jul 5, 2021

Explanation

Fixes #3130: Merged Switch click with TextViews in AdministratorControlsActivity

Similar to #3191 , this PR also merged the textviews with switch to make the entire area clickable. So basically Switch + 2 Texts are clickable.

There is no change in UI and also PR does not contain any attribute change related to UI.

Screenshot 2021-07-05 at 10 06 10 PM

Output

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oppiabot
Copy link

oppiabot bot commented Jul 5, 2021

Unassigning @anandwana001 since they have already approved the PR.

@rt4914 rt4914 merged commit 31851ca into develop Jul 5, 2021
@rt4914 rt4914 deleted the merge-admin_controls_downloads branch July 5, 2021 18:50
@rt4914 rt4914 mentioned this pull request Jul 5, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Administrator controls toggle radio buttons by clicking on the complete item
2 participants