Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #42: Highfi StateFragment xml files #3425

Merged
merged 1 commit into from
Jul 7, 2021
Merged

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Jul 7, 2021

Explanation

Fix #42: Highfi StateFragment xml files

This PR finishes the Highfi work of ExplorationPlayer.

In this PR I have merged state_fragment.xml files.

Resources for Audio Player margin

https://xd.adobe.com/view/dfe8ccd4-39eb-414d-a0b2-b5674357f966-8abb/screen/b73cb76c-3593-4a30-944a-ab240f00d0df/specs/
https://xd.adobe.com/view/dfe8ccd4-39eb-414d-a0b2-b5674357f966-8abb/screen/b1b1a013-eacd-48be-bf1f-a4f997db9d8d/specs/
https://xd.adobe.com/view/dfe8ccd4-39eb-414d-a0b2-b5674357f966-8abb/screen/281fb541-1b56-4a0d-b834-8bda14f0f07c/specs/
https://xd.adobe.com/view/dfe8ccd4-39eb-414d-a0b2-b5674357f966-8abb/screen/cceab1b2-ab25-4583-b91f-ea81905ed763/specs/
https://xd.adobe.com/view/dfe8ccd4-39eb-414d-a0b2-b5674357f966-8abb/screen/b4f695e2-9b71-4cac-b323-aec57c0c545c/specs/
https://xd.adobe.com/view/dfe8ccd4-39eb-414d-a0b2-b5674357f966-8abb/screen/0432cca9-ef00-4525-b1e1-a91ed709e5a9/specs/

Output (Padding w.r.t to Audio, Konfetti and congratulations)

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anandwana001 anandwana001 assigned rt4914 and unassigned anandwana001 Jul 7, 2021
@rt4914 rt4914 merged commit ef906e4 into develop Jul 7, 2021
@rt4914 rt4914 deleted the state-fragment-xml-highfi branch July 7, 2021 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full UI: ExplorationPlayerFragment/Activity
2 participants