Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3401: Introduced SplashScreenWelcomeMsg PlatformParameter #3441

Merged
merged 10 commits into from
Jul 8, 2021
Merged

Fix #3401: Introduced SplashScreenWelcomeMsg PlatformParameter #3441

merged 10 commits into from
Jul 8, 2021

Conversation

Arjupta
Copy link
Contributor

@Arjupta Arjupta commented Jul 8, 2021 •
edited

Explanation

Fixes #3401
This PR introduces SplashScreenWelcomeMsg PlatformParameter for testing the implementation of Compile Time Platform Parameters. Also this PR is a replica of #3405

Screenshots

Screenshot 2021-07-07 121030

Test 1 Test 2
Screenshot_1625639975 Screenshot_1625639982

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

jcqli
jcqli reviewed Jul 8, 2021
View reviewed changes
app/src/main/java/org/oppia/android/app/splash/SplashActivityPresenter.kt Outdated
)
}

private fun processParameterLoadingStatus(loadingStatus: AsyncResult<Unit>): Boolean {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe processPlatformParameters since "loading status" seems like a UI thing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

jcqli
jcqli reviewed Jul 8, 2021
View reviewed changes
app/src/sharedTest/java/org/oppia/android/app/testing/PlatformParameterIntegrationTest.kt Outdated
}
}

/** Returns a [TypeSafeMatcher] which checks for any [Toast] message in the screen. */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Write as // comment since we don't need a public KDoc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

jcqli
jcqli approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@jcqli jcqli left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few quick comments checking that this matches the original review, LGTM after those changes are made!

@Arjupta Arjupta mentioned this pull request Jul 8, 2021
Closed
@Arjupta
Reverted the Prod SplashActivityPresenter and made Second Test Case f…
3e2f462 
…or PlatformParameterIntegrationTest is made to run on Espresso only
@vinitamurthi vinitamurthi removed their assignment Jul 8, 2021
@Arjupta Arjupta mentioned this pull request Jul 8, 2021
Closed
8 tasks
@oppiabot
Copy link

oppiabot bot commented Jul 8, 2021

Unassigning @anandwana001 since the review is done.

@oppiabot
Copy link

oppiabot bot commented Jul 8, 2021

Hi @Arjupta, it looks like some changes were requested on this pull request by @anandwana001. PTAL. Thanks!

@Arjupta Arjupta assigned anandwana001 and unassigned Arjupta Jul 8, 2021
rt4914
rt4914 approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for code owner files.

@rt4914 rt4914 removed their assignment Jul 8, 2021
anandwana001
anandwana001 approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried few things like decor view and putting more delay, but it might take more time so we are going with the run only on espresso for this test testSplashTestActivity_updateEmptyDatabase_readDatabaseValues_checkWelcomeMsgIsVisible .

@anandwana001 anandwana001 assigned Arjupta and unassigned anandwana001 Jul 8, 2021
@Arjupta Arjupta removed their assignment Jul 8, 2021
@Arjupta
Copy link
Contributor Author

Arjupta commented Jul 8, 2021

@vinitamurthi assigning it back to you for merging

@jcqli jcqli merged commit 96e6131 into develop Jul 8, 2021
@jcqli jcqli deleted the platform-parameter-compile-time-param branch July 8, 2021 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

@vinitamurthi vinitamurthi vinitamurthi approved these changes

@anandwana001 anandwana001 anandwana001 approved these changes

@jcqli jcqli jcqli approved these changes

Assignees

@vinitamurthi vinitamurthi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce a demo PlatformParameter (Compile Time)
5 participants
@Arjupta @rt4914 @vinitamurthi @anandwana001 @jcqli