Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes part of #3363: Ignore flaky tests in AddProfileActivity #3447

Merged
merged 3 commits into from
Jul 13, 2021

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Jul 9, 2021

Explanation

Fixes part of #3363: Ignore flaky tests in AddProfileActivity

In AppProfileActivity 3 tests are passing and failing on different devices. Until we solve this error we are ignoring them so that other developers can work on other related items.

Output

Screenshot 2021-07-09 at 11 55 22 AM

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anandwana001 anandwana001 assigned rt4914 and unassigned anandwana001 Jul 9, 2021
@oppiabot oppiabot bot added the PR: LGTM label Jul 9, 2021
@rt4914 rt4914 changed the title Fixes part of #3363: Ignore flaky tests in AppProfileActivity Fixes part of #3363: Ignore flaky tests in AddProfileActivity Jul 9, 2021
@anandwana001
Copy link
Contributor

anandwana001 commented Jul 9, 2021

@Sparsh1212 Could you check the failing check here?

@rt4914 rt4914 mentioned this pull request Jul 9, 2021
8 tasks
@Sparsh1212
Copy link
Contributor

Sparsh1212 commented Jul 9, 2021

We have to add the failing files to test_file_exemptions.textproto
Please refer to the documentation of script_exemptions.proto on how to format the exemption in the textproto file.

Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking merge till test pass

@oppiabot oppiabot bot removed the PR: LGTM label Jul 13, 2021
@oppiabot
Copy link

oppiabot bot commented Jul 13, 2021

Hi, @rt4914, the LGTM Label has been removed because the changes were requested on this PR. Thanks!.

@rt4914 rt4914 merged commit 9a5c928 into develop Jul 13, 2021
@rt4914 rt4914 deleted the ignore-flaky-tests-add-profile branch July 13, 2021 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants