Fix #3287: Introduce Kotlin script to extract license texts #3450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in_required attribute in maven_install()
…ce-maven-pinning-artifacts
…ce-maven-pinning-artifacts
…ce-second-script-to-extract-license-texts
BenHenning
requested changes
Aug 9, 2021
There was a problem hiding this comment.
Thanks @prayutsu. Checked the changes & fully reviewed the tests. PTAL.
scripts/src/java/org/oppia/android/scripts/license/model/BUILD.bazel
Outdated
Show resolved
Hide resolved
scripts/src/java/org/oppia/android/scripts/maven/RetrieveLicenseTexts.kt
Outdated
Show resolved
Hide resolved
scripts/src/java/org/oppia/android/scripts/maven/RetrieveLicenseTexts.kt
Outdated
Show resolved
Hide resolved
scripts/src/java/org/oppia/android/scripts/maven/model/BUILD.bazel
Outdated
Show resolved
Hide resolved
scripts/src/java/org/oppia/android/scripts/maven/model/BUILD.bazel
Outdated
Show resolved
Hide resolved
scripts/src/javatests/org/oppia/android/scripts/maven/RetrieveLicenseTextsTest.kt
Outdated
Show resolved
Hide resolved
scripts/src/javatests/org/oppia/android/scripts/maven/RetrieveLicenseTextsTest.kt
Outdated
Show resolved
Hide resolved
scripts/src/javatests/org/oppia/android/scripts/maven/RetrieveLicenseTextsTest.kt
Outdated
Show resolved
Hide resolved
scripts/src/javatests/org/oppia/android/scripts/maven/RetrieveLicenseTextsTest.kt
Outdated
Show resolved
Hide resolved
scripts/src/javatests/org/oppia/android/scripts/maven/RetrieveLicenseTextsTest.kt
Outdated
Show resolved
Hide resolved
…ce-second-script-to-extract-license-texts
BenHenning
approved these changes
Aug 10, 2021
scripts/src/java/org/oppia/android/scripts/maven/GenerateLicenseTexts.kt
Outdated
Show resolved
Hide resolved
scripts/src/javatests/org/oppia/android/scripts/maven/RetrieveLicenseTextsTest.kt
Show resolved
Hide resolved
scripts/src/javatests/org/oppia/android/scripts/maven/RetrieveLicenseTextsTest.kt
Outdated
Show resolved
Hide resolved
GSoC 2021.6: Support for displaying copyright licenses
automation
moved this from In progress
to Done
Aug 10, 2021
BenHenning
deleted the
introduce-second-script-to-extract-license-texts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Fixes #3287:
Created a Kotlin script that extracts the license texts for the third-party maven dependencies.
To run the script, run the following command -
As an output of the script, 5 files would get generated (resource XML files) that will be used to finally show these licenses in the UI. Note that these files should never be directly checked into the codebase.
They will only be generated by the maintainers at the time of preparing for a release.
Screenshot of passing test cases-
Files generated by the script can be seen here -
https://gist.github.com/prayutsu/7693dabae98370ca000d959efaff0058
Checklist