Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3406: [RTL] High-fi Recently- Played Activity List #3466

Merged
merged 70 commits into from
Aug 12, 2021

Conversation

veena14cs
Copy link
Contributor

@veena14cs veena14cs commented Jul 12, 2021

Explanation

This PR fixes #3406 . This PR fixes rtl support in ongoingStoryCard.

Screenshot LTR and RTL

Mobile:
screenshot.......screenshot

screenshot....screenshot

Tablet:

screenshot....screenshot

screenshot......screenshot

Tests with RTL code

Screenshot (53)

Tests without RTL code fails as expected

Screenshot (54)

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@veena14cs veena14cs requested a review from rt4914 as a code owner July 12, 2021 20:58
@veena14cs
Copy link
Contributor Author

I have merged with latest develop. This might fix CI.

@veena14cs veena14cs removed their assignment Aug 10, 2021
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @veena14cs. LGTM!

@BenHenning
Copy link
Sponsor Member

(also assigning back to @anandwana001, not sure if you meant to do that earlier)

@veena14cs
Copy link
Contributor Author

(also assigning back to @anandwana001, not sure if you meant to do that earlier)

Yes thanks.

@veena14cs veena14cs removed their assignment Aug 10, 2021
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
not the code owner for this PR, but keeping track of merging once all the checks pass.

@oppiabot oppiabot bot added the PR: LGTM label Aug 11, 2021
@veena14cs veena14cs merged commit 86d0d1f into oppia:develop Aug 12, 2021
@veena14cs veena14cs deleted the fix-recently-played branch August 12, 2021 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: LGTM Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RTL] High-fi Recently- Played Activity List
5 participants