Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3435: Added content description for Hints and Solution bulb #3475

Merged
merged 2 commits into from
Jul 14, 2021

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Jul 13, 2021

Explanation

Fixes #3435: Added content description for Hints and Solution bulb

This PR adds test for this in StateFragmentTest file but for QuestionPlayerTest we do not have hints correctly and therefore I have added this comment for future reference.

Output

a11y_hints_and_solution.mp4

Screenshot 2021-07-13 at 10 51 16 PM

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@rt4914 rt4914 requested a review from anandwana001 July 13, 2021 16:20
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anandwana001 anandwana001 merged commit 984a19c into develop Jul 14, 2021
@anandwana001 anandwana001 deleted the content-description-hint-bulb branch July 14, 2021 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[A11y] Add content description for Hint bulb icon
2 participants