Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2131: Question Player Progress bar background and margins #3477

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Jul 13, 2021

Explanation

Fix #2131: Question Player Progress bar background and margins

Resources

Mobile
Tablet

Notes

  • In Mobile-Portrait the external margins is 32dp, which matches with the content-item-external-margins. Therefore from this logic and consistency factor I have kept external margins as 64dp for mobile landscape mode.
  • In Tablet-Portrait the external margins is 64dp which is 1/2 of 128dp which again matches with the content-item-external-margins. Applying this same logic I have kept external margins for Tablet-Landscape as 96dp.

Output

I have sharing screenshots focusing on following points:

  1. Default view of progress bar
  2. Progress bar with hint bulb
  3. Progress bar with content behind it - gradient visible

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anandwana001 anandwana001 merged commit 09b6e59 into develop Jul 14, 2021
@anandwana001 anandwana001 deleted the progress-bar-shade-fix branch July 14, 2021 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Progress Bar is present when keyboard is active
2 participants