Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3495 and #3496: Add support for displaying dependencies list and their license texts #3501

Merged
merged 50 commits into from
Aug 9, 2021
Merged

Fix #3495 and #3496: Add support for displaying dependencies list and their license texts #3501

merged 50 commits into from
Aug 9, 2021

Conversation

prayutsu
Copy link
Contributor

@prayutsu prayutsu commented Jul 18, 2021 •
edited

Explanation

Fixes #3495 and Fixes #3496:

Hooked up a new UI to display the third-party dependencies used to build Oppia Android.
Mock link - https://xd.adobe.com/view/e8aa4198-3940-47f9-514a-f41cc54457f6-9e9b/screen/0f94055a-c5f7-45a2-8bf5-9dcfdf1c7dce/specs/

a11y

License Text License List
Screenshot_2021-08-04-11-03-03-278_com google android apps accessibility auditor Screenshot_2021-08-04-11-03-01-649_com google android apps accessibility auditor
Dependency List Help
Screenshot_2021-08-04-11-03-00-043_com google android apps accessibility auditor Screenshot_2021-08-04-11-02-57-917_com google android apps accessibility auditor

a11y with RTL

License Text License List
Screenshot_1628055545 Screenshot_1628055543
Help Dependency List
Screenshot_1628055537 Screenshot_1628055540

Tests

Screenshot from 2021-07-25 23-51-57
Screenshot from 2021-07-28 15-40-20
Screenshot from 2021-07-25 23-48-29
Screenshot from 2021-07-29 13-52-33

Screenshot from 2021-07-25 23-46-58
Screenshot from 2021-07-28 15-33-58
Screenshot from 2021-07-25 23-43-38

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@prayutsu prayutsu self-assigned this Jul 18, 2021
@prayutsu prayutsu changed the title [WIP] Fix #3495: Add support for displaying dependencies list via Help Menu Fix #3495: Add support for displaying dependencies list via Help Menu Jul 24, 2021
@prayutsu prayutsu marked this pull request as ready for review July 24, 2021 16:33
@prayutsu prayutsu assigned rt4914 and unassigned rt4914 and prayutsu Jul 24, 2021
rt4914
rt4914 suggested changes Jul 25, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prayutsu I have checked the PR from ViewModel's perspective. It does look good. I have left some other comments which I thought of.

Also, note that once the PR is complete from your side, you will need to add RTL and A11y output too.

app/src/main/AndroidManifest.xml Outdated Show resolved Hide resolved
app/src/main/java/org/oppia/android/app/help/HelpActivity.kt Outdated Show resolved Hide resolved
app/src/main/java/org/oppia/android/app/help/HelpActivity.kt Show resolved Hide resolved
app/src/main/java/org/oppia/android/app/help/thirdparty/ThirdPartyDependencyListActivity.kt Outdated Show resolved Hide resolved
...main/java/org/oppia/android/app/help/thirdparty/ThirdPartyDependencyListActivityPresenter.kt Outdated Show resolved Hide resolved
...main/java/org/oppia/android/app/help/thirdparty/ThirdPartyDependencyListFragmentPresenter.kt Outdated Show resolved Hide resolved
...main/java/org/oppia/android/app/help/thirdparty/ThirdPartyDependencyListFragmentPresenter.kt Outdated Show resolved Hide resolved
...main/java/org/oppia/android/app/help/thirdparty/ThirdPartyDependencyListFragmentPresenter.kt Outdated Show resolved Hide resolved
app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
@rt4914 rt4914 assigned prayutsu and unassigned rt4914 Jul 25, 2021
BenHenning
BenHenning reviewed Aug 5, 2021
View reviewed changes
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @prayutsu. Mostly nits left. PTAL.

app/src/main/res/values/third_party_dependencies.xml Outdated Show resolved Hide resolved
app/src/main/java/org/oppia/android/app/help/thirdparty/RouteToLicenseTextListener.kt Outdated Show resolved Hide resolved
app/src/main/java/org/oppia/android/app/help/thirdparty/RouteToLicenseListListener.kt Outdated Show resolved Hide resolved
app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
@BenHenning BenHenning assigned rt4914 and prayutsu and unassigned BenHenning Aug 5, 2021
@prayutsu prayutsu assigned BenHenning and unassigned prayutsu and rt4914 Aug 5, 2021
BenHenning
BenHenning reviewed Aug 6, 2021
View reviewed changes
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @prayutsu. Primarily one follow-up for something that I missed earlier. PTAL.

app/src/main/res/values/third_party_dependencies.xml Show resolved Hide resolved
@BenHenning BenHenning assigned prayutsu and unassigned BenHenning Aug 6, 2021
@prayutsu prayutsu assigned BenHenning and unassigned prayutsu Aug 6, 2021
@prayutsu
Copy link
Contributor Author

prayutsu commented Aug 6, 2021

@BenHenning PTAL.

BenHenning
BenHenning reviewed Aug 6, 2021
View reviewed changes
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @prayutsu. Per codeowners, this LGTM, just had 1 nit. PTAL.

app/src/main/res/values/third_party_dependencies.xml Show resolved Hide resolved
@BenHenning
Copy link
Sponsor Member

Also, @prayutsu could you please update this to the latest develop & address the conflict?

@BenHenning BenHenning assigned prayutsu and unassigned BenHenning Aug 6, 2021
@prayutsu prayutsu assigned BenHenning and unassigned prayutsu Aug 6, 2021
@prayutsu
Copy link
Contributor Author

prayutsu commented Aug 9, 2021

@BenHenning PTAL.

@BenHenning
Copy link
Sponsor Member

Hi. Will need to look at this tomorrow.

BenHenning
BenHenning approved these changes Aug 9, 2021
View reviewed changes
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @prayutsu. LGTM!

@BenHenning BenHenning merged commit 3c09951 into develop Aug 9, 2021
GSoC 2021.6: Support for displaying copyright licenses automation moved this from In progress to Done Aug 9, 2021
@BenHenning BenHenning deleted the display-dependencies-list branch August 9, 2021 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

@BenHenning BenHenning BenHenning approved these changes

Assignees

@BenHenning BenHenning

Labels
None yet
Projects
No open projects
GSoC 2021.6: Support for displaying c...
Done
Milestone
No milestone
5 participants
@prayutsu @rt4914 @BenHenning @anandwana001 @Sparsh1212