-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3309 and #3311: Implement Force Network Type Feature #3502
Conversation
I have marked this PR as draft as I have not written the tests as of now. I'm waiting on the approval on PR #3471 and then will follow the same approach to write tests here. Also, the UI needs updates as I have to implement the logic for the selection of network types. That might depend on issue #3310. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yashraj-01. Had one follow-up.
.../java/org/oppia/android/app/devoptions/forcenetworktype/ForceNetworkTypeFragmentPresenter.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yashraj-01. This LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for code owner files.
Explanation
Fixes #3309. Introduced UI for Force Network Type screen.
Fixes #3311. Implemented logic to force network type.
This PR also fixes #3379. cc: @rt4914
Mock link: https://xd.adobe.com/view/e8aa4198-3940-47f9-514a-f41cc54457f6-9e9b/screen/8ae1a60e-7f6d-4b7b-b741-469bb80007b9/specs/
Screenshots
UI
Espresso tests passing for
DeveloperOptionsFragmentTest
Espresso tests passing for
ForceNetworkTypeActivityTest
Espresso tests passing for
ForceNetworkTypeFragmentTest
Checklist