Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3309 and #3311: Implement Force Network Type Feature #3502

Merged
merged 91 commits into from
Aug 18, 2021

Conversation

yashraj-01
Copy link
Contributor

@yashraj-01 yashraj-01 commented Jul 18, 2021

Explanation

Fixes #3309. Introduced UI for Force Network Type screen.
Fixes #3311. Implemented logic to force network type.
This PR also fixes #3379. cc: @rt4914

Mock link: https://xd.adobe.com/view/e8aa4198-3940-47f9-514a-f41cc54457f6-9e9b/screen/8ae1a60e-7f6d-4b7b-b741-469bb80007b9/specs/

Screenshots

  • UI

  • Espresso tests passing for DeveloperOptionsFragmentTest
    Screenshot from 2021-07-31 20-04-10

  • Espresso tests passing for ForceNetworkTypeActivityTest
    Screenshot from 2021-07-31 21-16-47

  • Espresso tests passing for ForceNetworkTypeFragmentTest
    Screenshot from 2021-07-31 22-10-29

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@yashraj-01
Copy link
Contributor Author

I have marked this PR as draft as I have not written the tests as of now. I'm waiting on the approval on PR #3471 and then will follow the same approach to write tests here. Also, the UI needs updates as I have to implement the logic for the selection of network types. That might depend on issue #3310. Thanks.

@yashraj-01 yashraj-01 changed the title Fix #3309: Introduce UI for Force Network Type Fix #3309: Introduce UI for Force Network Type [BLOCKED on PR #3512] Jul 21, 2021
@yashraj-01 yashraj-01 changed the base branch from develop to prod-and-debug-networkconnectionutil July 29, 2021 16:29
@yashraj-01 yashraj-01 assigned BenHenning and unassigned yashraj-01 Aug 13, 2021
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yashraj-01. Had one follow-up.

@BenHenning BenHenning assigned yashraj-01 and unassigned BenHenning Aug 13, 2021
Base automatically changed from prod-and-debug-networkconnectionutil to develop August 17, 2021 10:10
@yashraj-01 yashraj-01 changed the title Fix #3309 and #3311: Implement Force Network Type Feature [BLOCKED on PR #3512] Fix #3309 and #3311: Implement Force Network Type Feature Aug 17, 2021
@yashraj-01 yashraj-01 removed the request for review from vinitamurthi August 17, 2021 12:04
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yashraj-01. This LGTM!

@BenHenning BenHenning removed their assignment Aug 18, 2021
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for code owner files.

@oppiabot oppiabot bot added the PR: LGTM label Aug 18, 2021
@anandwana001 anandwana001 merged commit 5d71407 into develop Aug 18, 2021
@anandwana001 anandwana001 deleted the ui-force-network-type branch August 18, 2021 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
7 participants