Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3592: [RTL] High-fi Add support for RTL in audio player and other drawables included in Oppia #3593

Merged
merged 47 commits into from
Aug 9, 2021

Conversation

veena14cs
Copy link
Contributor

@veena14cs veena14cs commented Jul 27, 2021

Explanation

This PR fixes #3592 . This PR fixes drawables used in Audio Player and also other drawables used in the project.

Screenshot LTR and RTL

Audio Player

screenshot..... Screenshot_1627385683

screenshot.... Screenshot_1627385690

Profile exit icon in Navigation Drawer

Screenshot_1627642888.......Screenshot_1627642209

Note : This screenshot only focus on audio player drawbles and not the image in exploration player.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, before merging it, can we add a screenshot of all the screens contacting all the images which are updated here in PR.

Also, should we add test for these?

@veena14cs
Copy link
Contributor Author

LGTM, before merging it, can we add a screenshot of all the screens contacting all the images which are updated here in PR.

Also, should we add test for these?

I m not sure of testcases. And regarding screenshots there are too many files actually to show LTR and RTL.

@veena14cs veena14cs removed their assignment Jul 28, 2021
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@veena14cs PTAL

app/src/main/res/drawable/ic_refresh_white_24dp.xml Outdated Show resolved Hide resolved
@@ -1,6 +1,7 @@
<vector xmlns:android="http://schemas.android.com/apk/res/android"
android:width="24dp"
android:height="24dp"
android:autoMirrored="true"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MohamedMedhat1998 Can you help us out in deciding what should be RTL behaviour of this icon:

Screenshot 2021-08-04 at 10 38 37 PM

  1. If we do not mirror it it will look exactly same in RTL too.
  2. If we mirror it fully than the text will be mirrored too which means that the character in foreign language will also get mirrored meaning it won't be a valid character anymore. So definitely we cannot do this.

Screenshot 2021-08-04 at 10 41 16 PM

3. Another option we have is to mirror the bubble/background only and keep the text exactly same for RTL.

What are your thoughts? What would be the best solution here?

@BenHenning BenHenning self-requested a review August 5, 2021 07:33
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clearing my review since the approach overall looks correct, we just need to find a solution for the audio language icon.

@BenHenning BenHenning dismissed their stale review August 5, 2021 07:34

Dismissing per previous comment.

@BenHenning BenHenning removed their assignment Aug 5, 2021
@veena14cs
Copy link
Contributor Author

Clearing my review since the approach overall looks correct, we just need to find a solution for the audio language icon.

Thanks Ben!

@veena14cs veena14cs requested a review from rt4914 August 6, 2021 21:15
@veena14cs veena14cs assigned rt4914 and unassigned veena14cs Aug 6, 2021
@veena14cs veena14cs added this to the RTL Support milestone Aug 6, 2021
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@veena14cs I am unblocking you so that this PR can be merged but just undo the change in ic_audio_lang_24px and after which this PR can be merged.

@rt4914 rt4914 assigned veena14cs and unassigned rt4914 Aug 7, 2021
@oppiabot oppiabot bot added the PR: LGTM label Aug 7, 2021
@veena14cs
Copy link
Contributor Author

@veena14cs I am unblocking you so that this PR can be merged but just undo the change in ic_audio_lang_24px and after which this PR can be merged.

Thanks @rt4914 reverted changes done in ic_audio_lang_24px.

@veena14cs veena14cs removed the PR don't merge - NEEDS UPDATE Corresponds to PRs that need to be updated with the latest develop changes before they can be merged label Aug 8, 2021
@veena14cs veena14cs merged commit 5cb24b2 into oppia:develop Aug 9, 2021
@veena14cs veena14cs deleted the fix-drawables-rtl branch August 9, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RTL] High-fi Add support for RTL in audio player and other drawables included in Oppia
6 participants