Fix #3532: Deleted help_activity.xml (land) file

[UttaranDas]

Explanation

Fix #3532
I have deleted the help_activity.xml (land) file. I compared the two xml files and found just one difference which was the android:layout_width. It was set to match_parent in the normal file whereas it was set to 304dp in land xml file. Deleting the land xml file changed the width of the drawer for the landscape mode. The app works stable so far. Following are the screenshots attached:

Before	After

Drawer Screenshots

Before	After

Checklist

• The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
• The PR follows the style guide.
• The PR does not contain any unnecessary auto-generated code from Android Studio.
• The PR is made from a branch that's not called "develop".
• The PR is made from a branch that is up-to-date with "develop".
• The PR's branch is based on "develop" and not on any other branch.
• The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

[rt4914]

@Noobmaster-UD The 304dp width was for the Drawer not for the help activity. Take screenshots of Drawer too.

[UttaranDas]

@rt4914 I have uploaded the Drawer screenshots in the PR now. PTAL

[oppiabot]

Unassigning @Noobmaster-UD since a re-review was requested. @Noobmaster-UD, please make sure you have addressed all review comments. Thanks!

[rt4914]

@UttaranDas The drawer screenshots are incorrect. The drawer should be opened in HelpActivity and then you should take the screenshots and compare them. Currently you have taken screenshots on HomeActivity.

[UttaranDas]

@UttaranDas The drawer screenshots are incorrect. The drawer should be opened in HelpActivity and then you should take the screenshots and compare them. Currently you have taken screenshots on HomeActivity.

I have now updated the PR with the correct screenshots.
I couldn't find any way to use land dimens without using land xml.

[rt4914]

@UttaranDas The drawer screenshots are incorrect. The drawer should be opened in HelpActivity and then you should take the screenshots and compare them. Currently you have taken screenshots on HomeActivity.

I have now updated the PR with the correct screenshots.
I couldn't find any way to use land dimens without using land xml.

@UttaranDas Do one thing, in help_activity.xml change the layout_width of help_activity_fragment_navigation_drawer from match_parent to @dimens/navigation_drawer_width and define this navigation_drawer_width in dimens file as 304dp.

This will make UI change but this is correct.

This was you will need to keep only one file and the UI output will be much pleasant.

[UttaranDas]

@UttaranDas The drawer screenshots are incorrect. The drawer should be opened in HelpActivity and then you should take the screenshots and compare them. Currently you have taken screenshots on HomeActivity.

I have now updated the PR with the correct screenshots.
I couldn't find any way to use land dimens without using land xml.

@UttaranDas Do one thing, in help_activity.xml change the layout_width of help_activity_fragment_navigation_drawer from match_parent to @dimens/navigation_drawer_width and define this navigation_drawer_width in dimens file as 304dp.

This will make UI change but this is correct.

This was you will need to keep only one file and the UI output will be much pleasant.

I made the changes. Now the drawer looks like this:

Before	After

@rt4914 PTAL

[oppiabot]

Unassigning @UttaranDas since a re-review was requested. @UttaranDas, please make sure you have addressed all review comments. Thanks!

[rt4914]

One nit change suggested. Thanks.

[oppiabot]

Hi @UttaranDas, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 3 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!