Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3605: Introduce Platform Parameter WorkManager classes #3606

Merged
merged 71 commits into from
Aug 20, 2021
Merged

Fix #3605: Introduce Platform Parameter WorkManager classes #3606

merged 71 commits into from
Aug 20, 2021

Conversation

Arjupta
Copy link
Contributor

@Arjupta Arjupta commented Jul 28, 2021 •
edited

Explanation

Fixes #3605
Introduced a Lightweight Syncing mechanism for PlatformParameter with the help of Work Manager. This PR was stacked over #3489

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@Arjupta
Added GaeModels + PlatformParameterService and its Mock
405fc44
@Arjupta
Trying to fix bazel check by adding dependency over data module
c51a184
@Arjupta
Changed the location of MockService to testing/network and of Service…
d7a01c5 
…Test to data
@Arjupta
Bazel changes for TestConstants alomng with moving these constants in…
b2aa553 
…to new file
@Arjupta
Nit change in the bazel package name
3de99ed
@Arjupta
Adding platform parameter BUILD.bazel as a dependency in testing
cc6e47a
@Arjupta
Adding test_constants in testing/network BUILD.bazel and utility in t…
1879820 
…esting/platformparameter BUILD.bazel
@Arjupta
Suggested changes related to exemption file, renaming test constants …
44dabec 
…and Gae models also adding test cases in Service test and documentation over Gae models
@Arjupta
Nit change related to TODO issue number
ffcc93a
@Arjupta
Reverting to the original response structure from backend. Removed Ga…
e36b11b 
…eModels and used a Map<String,Any> instead
@Arjupta
Updating with develop
235208a
@Arjupta
Removed GaeModels from exemptions file & platform parameter from TEST…
779282d 
…_DEPS of testing module
@Arjupta
Nit change for renaming test function
0309e33
@Arjupta
Nit change for adding named arguments
8586e6f
@Arjupta
Suggested change for testing request query, new files for test constants
f59305d 
and KDoc changes
@Arjupta
Static checks and updating exemption file
c642b47
@Arjupta
Updating with develop
d354c05
@Arjupta
Basic commit for introducing a Worker, WorkerFactory and WorkerInitia…
7108509 
…lizer
@Arjupta
Including all the files related to Platform Parameter Worker.
57dfce4
@Arjupta
SyncUp worker tests are running fine. Commented out Prod Platform Par…
76515bf 
…ameter Service Impl in Network Module
@Arjupta
Added the tests for SyncUpWorkManagerInitializer
0c05d72
@Arjupta
Introduced TestNetworkModule in the tests to remove the dependency fr…
0cb44cb 
…om NetworkModule
@Arjupta
Modified exemption file to exclude Worker Factory and Module
e310e9e
@Arjupta Arjupta added this to the GSoC 2021.4: Milestone 2 milestone Jul 28, 2021
@oppiabot
Copy link

oppiabot bot commented Aug 17, 2021

Unassigning @vinitamurthi since they have already approved the PR.

BenHenning
BenHenning reviewed Aug 18, 2021
View reviewed changes
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Arjupta. Followed up on all recent changes/comments. PTAL.

...pia/android/domain/platformparameter/syncup/PlatformParameterSyncUpWorkManagerInitializer.kt Outdated Show resolved Hide resolved
utility/src/main/java/org/oppia/android/util/platformparameter/PlatformParameterConstants.kt Outdated Show resolved Hide resolved
...android/domain/platformparameter/syncup/PlatformParameterSyncUpWorkManagerInitializerTest.kt Outdated Show resolved Hide resolved
.../src/test/java/org/oppia/android/domain/platformparameter/PlatformParameterControllerTest.kt Outdated Show resolved Hide resolved
...main/java/org/oppia/android/domain/platformparameter/syncup/PlatformParameterSyncUpWorker.kt Outdated Show resolved Hide resolved
...android/domain/platformparameter/syncup/PlatformParameterSyncUpWorkManagerInitializerTest.kt Outdated Show resolved Hide resolved
.../java/org/oppia/android/domain/platformparameter/syncup/PlatformParameterSyncUpWorkerTest.kt Show resolved Hide resolved
...main/java/org/oppia/android/domain/platformparameter/syncup/PlatformParameterSyncUpWorker.kt Outdated Show resolved Hide resolved
...main/java/org/oppia/android/domain/platformparameter/syncup/PlatformParameterSyncUpWorker.kt Outdated Show resolved Hide resolved
...pia/android/domain/platformparameter/syncup/PlatformParameterSyncUpWorkManagerInitializer.kt Outdated Show resolved Hide resolved
@BenHenning
Copy link
Sponsor Member

Also @Arjupta I suggest syncing with the latest develop changes & updating this PR accordingly.

@BenHenning BenHenning assigned Arjupta and unassigned BenHenning Aug 18, 2021
@Arjupta Arjupta assigned BenHenning and unassigned Arjupta Aug 18, 2021
BenHenning
BenHenning requested changes Aug 19, 2021
View reviewed changes
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Arjupta. Just a couple of new comments, and one existing thread that I think hasn't yet been resolved. Other than these last few comments the PR LGTM.

PTAL.

...pia/android/domain/platformparameter/syncup/PlatformParameterSyncUpWorkManagerInitializer.kt Outdated Show resolved Hide resolved
...pia/android/domain/platformparameter/syncup/PlatformParameterSyncUpWorkManagerInitializer.kt Show resolved Hide resolved
...main/java/org/oppia/android/domain/platformparameter/syncup/PlatformParameterSyncUpWorker.kt Outdated Show resolved Hide resolved
...pia/android/domain/platformparameter/syncup/PlatformParameterSyncUpWorkManagerInitializer.kt Outdated Show resolved Hide resolved
@BenHenning BenHenning assigned Arjupta and unassigned BenHenning Aug 19, 2021
@Arjupta Arjupta assigned BenHenning and unassigned Arjupta Aug 20, 2021
BenHenning
BenHenning approved these changes Aug 20, 2021
View reviewed changes
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Arjupta. This LGTM!

...main/java/org/oppia/android/domain/platformparameter/syncup/PlatformParameterSyncUpWorker.kt Outdated Show resolved Hide resolved
@BenHenning
Copy link
Sponsor Member

Given other threads seem resolved & everyone has approved, merging this.

@BenHenning BenHenning merged commit b1a5979 into develop Aug 20, 2021
@BenHenning BenHenning deleted the platform-parameter-work-manager branch August 20, 2021 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcqli jcqli jcqli approved these changes

@rt4914 rt4914 rt4914 approved these changes

@vinitamurthi vinitamurthi vinitamurthi approved these changes

@BenHenning BenHenning BenHenning approved these changes

@anandwana001 anandwana001 anandwana001 approved these changes

Assignees

@BenHenning BenHenning

Labels
None yet
Projects
No open projects
GSoC 2021.4: Feature Flags & Platform...
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce Lightweight Syncing Mechanism for Platform Parameters
8 participants
@Arjupta @BenHenning @rt4914 @vinitamurthi @anandwana001 @jcqli @fsharpasharp @Sparsh1212