Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3317: Update old todos #3610

Merged
merged 16 commits into from
Aug 6, 2021
Merged

Fix #3317: Update old todos #3610

merged 16 commits into from
Aug 6, 2021

Conversation

Sparsh1212
Copy link
Contributor

@Sparsh1212 Sparsh1212 commented Jul 29, 2021

Explanation

Fixes #3317: Correct poorly formatted todos and update those which doesn't correspond to an open issue.

Issues that we should reopen because they aren't resolved, or issues which have additional work to complete:

Issues whose TODOs need to be repurposed to new/other issues:

Issues whose TODOs are also resolved and thus should be removed from code, or TODOs which do not need to be resolved:

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@Sparsh1212 Sparsh1212 marked this pull request as draft July 29, 2021 21:03
Copy link
Contributor

@vinitamurthi vinitamurthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for codeowner files!

@vinitamurthi vinitamurthi removed their assignment Aug 2, 2021
@oppiabot
Copy link

oppiabot bot commented Aug 2, 2021

Assigning @BenHenning for code owner reviews. Thanks!

Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code owner files LGTM

@anandwana001 anandwana001 removed their assignment Aug 2, 2021
Copy link
Contributor

@Sarthak2601 Sarthak2601 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for #1104's to-do change.

@Sarthak2601 Sarthak2601 removed their assignment Aug 2, 2021
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for code-owner files. Thanks

@rt4914 rt4914 removed their assignment Aug 2, 2021
@Sparsh1212 Sparsh1212 assigned Sparsh1212 and unassigned BenHenning Aug 2, 2021
@Sparsh1212
Copy link
Contributor Author

@BenHenning I and @prayutsu did some research on the TODO for issue #322, but we weren't able to reach a conclusion. It looks like it needs a deeper investigation. Repurposed the current TODO to a new issue so that this doesn't block this PR.

@Sparsh1212 Sparsh1212 assigned BenHenning and unassigned Sparsh1212 Aug 4, 2021
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Sparsh1212. Generally LGTM, just looking to get confirmation from two other team members before approving these updates.

It's great to see the TODOs becoming up-to-date & correctly formatted. :)

@anandwana001 anandwana001 removed their assignment Aug 5, 2021
@Sparsh1212 Sparsh1212 removed their assignment Aug 5, 2021
@Sparsh1212
Copy link
Contributor Author

Copy link
Contributor

@jcqli jcqli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for issue #3016! Thanks for your patience

@jcqli jcqli assigned Sparsh1212 and unassigned jcqli Aug 5, 2021
@BenHenning
Copy link
Sponsor Member

@Sparsh1212 let's file a new issue to track the work for #114's TODO.

@Sparsh1212
Copy link
Contributor Author

@BenHenning Filed new issue #3646 as a replacement for #114. PTAL.

@Sparsh1212 Sparsh1212 assigned BenHenning and unassigned Sparsh1212 Aug 5, 2021
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Sparsh1212! LGTM.

@BenHenning
Copy link
Sponsor Member

BenHenning commented Aug 6, 2021

Merging since the Bazel tests should be fine, and they seem to be hanging at the moment.

@BenHenning BenHenning merged commit 2b33802 into develop Aug 6, 2021
@BenHenning BenHenning deleted the fix-todos branch August 6, 2021 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update all the TODOs of the repository that are not updated correctly
7 participants