-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RunAllTests] Fix #3633: [RTL] High fi Onboarding images supports RTL #3635
Conversation
@veena14cs I think this is incorrect. In RTL landscape we should only reverse the background and not the foreground. |
As discussed in the email thread, we are keeping RTL for the entire image as shown in the screenshots in the PR description. In that case @rt4914 please review this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving and also filed an issue for the same. #3655
Explanation
This PR fixes #3633. The PR focuses on fixing RTL for Onboading images
Screenshot LTR and RTL
Mobile Portrait:
.....
.....
.....
.......
Mobile Landscape:
......
........
.......
....
Tablet Portrait:
......
....
....
.....
Tablet Landscape:
....
....
.....
.....
Checklist