Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3553 : Deleted merge_options_fragment.xml(land) #3639

Conversation

Rohit1173
Copy link
Contributor

Explanation

Fix #3553
I have deleted the options_fragment.xml(land) file because when I compared options_fragment.xml and options_fragment.xml(land)
both were identical and after deleting the file there were no changes in the app.
Here are the before and after screenshots of the options_fragment.xml file

BEFORE AFTER
before-1 after-1
before-2 after-2
before-3 after-3
before-4 after-4

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@Rohit1173 Rohit1173 requested a review from rt4914 as a code owner August 4, 2021 07:01
@Rohit1173 Rohit1173 changed the title Deleted merge_options_fragment.xml(land) Fix #3553 : Deleted merge_options_fragment.xml(land) Aug 4, 2021
@Rohit1173
Copy link
Contributor Author

@anandwana001 @rt4914 PTAL

Copy link
Contributor

@prayutsu prayutsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Rohit1173.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 merged commit eb10260 into oppia:develop Aug 4, 2021
@Rohit1173 Rohit1173 deleted the merge_options_fragment.xml_into_single_xml_file branch August 4, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge options_fragment.xml into single xml file
4 participants