Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3651: [RTL] High-fi rotation animation for icon in Topic lesson and Hints and Solution #3652

Merged
merged 49 commits into from
Aug 11, 2021

Conversation

veena14cs
Copy link
Contributor

@veena14cs veena14cs commented Aug 6, 2021

Explanation

This PR fixes #3651. This PR fixes expand/collapse icon for RTL.

Test with new RTL code passes as expected.

Screenshot (57)

Test without new RTL codes fails as expected.

Screenshot (60)

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@veena14cs veena14cs requested a review from rt4914 August 8, 2021 12:11
@veena14cs veena14cs assigned rt4914 and anandwana001 and unassigned veena14cs Aug 8, 2021
@veena14cs
Copy link
Contributor Author

Thanks, @veena14cs

I haven't reviewed it in detail, looks like few changes. I will check the tests tomorrow.

Thanks @anandwana001 I have addressed your comments PTAL.

@veena14cs
Copy link
Contributor Author

@veena14cs Can you please self review this PR? Looks like there as some unwanted changes also the branch is not up-to-date with develop.

Fixed unwanted changes PTAL.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested nit changes. Otherwise LGTM

@rt4914 rt4914 removed their assignment Aug 8, 2021
@oppiabot
Copy link

oppiabot bot commented Aug 8, 2021

Assigning @BenHenning for code owner reviews. Thanks!

Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anandwana001 anandwana001 removed their assignment Aug 9, 2021
@veena14cs veena14cs removed their assignment Aug 9, 2021
@BenHenning
Copy link
Sponsor Member

Hi. Will need to look at this tomorrow.

Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @veena14cs. I'm glad we were able to effectively test this. PR LGTM!

@BenHenning BenHenning merged commit 77ff836 into oppia:develop Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RTL] High-fi Rotation animation need to support RTL
4 participants