-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3651: [RTL] High-fi rotation animation for icon in Topic lesson and Hints and Solution #3652
Conversation
Thanks @anandwana001 I have addressed your comments PTAL. |
Fixed unwanted changes PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested nit changes. Otherwise LGTM
app/src/main/java/org/oppia/android/app/databinding/ViewBindingAdapters.java
Outdated
Show resolved
Hide resolved
app/src/main/res/layout/activity_view_binding_adapters_test.xml
Outdated
Show resolved
Hide resolved
Assigning @BenHenning for code owner reviews. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi. Will need to look at this tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @veena14cs. I'm glad we were able to effectively test this. PR LGTM!
Explanation
This PR fixes #3651. This PR fixes expand/collapse icon for RTL.
Test with new RTL code passes as expected.
Test without new RTL codes fails as expected.
Checklist