Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3674: Added new test cases in PlatformParameterIntegrationTest #3675

Merged
merged 93 commits into from
Aug 21, 2021
Merged

Fix #3674: Added new test cases in PlatformParameterIntegrationTest #3675

merged 93 commits into from
Aug 21, 2021

Conversation

Arjupta
Copy link
Contributor

@Arjupta Arjupta commented Aug 12, 2021

Explanation

Fixed #3674
Updated PlatformParameterIntegrationTest to include test based on refreshing with SyncUpWorker.

Target PR date: 11 August 2021
Target completion date: 16 August 2021

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@Arjupta
Added GaeModels + PlatformParameterService and its Mock
405fc44
@Arjupta
Trying to fix bazel check by adding dependency over data module
c51a184
@Arjupta
Changed the location of MockService to testing/network and of Service…
d7a01c5 
…Test to data
@Arjupta
Bazel changes for TestConstants alomng with moving these constants in…
b2aa553 
…to new file
@Arjupta
Nit change in the bazel package name
3de99ed
@Arjupta
Adding platform parameter BUILD.bazel as a dependency in testing
cc6e47a
@Arjupta
Adding test_constants in testing/network BUILD.bazel and utility in t…
1879820 
…esting/platformparameter BUILD.bazel
@Arjupta
Suggested changes related to exemption file, renaming test constants …
44dabec 
…and Gae models also adding test cases in Service test and documentation over Gae models
@Arjupta
Nit change related to TODO issue number
ffcc93a
@Arjupta
Reverting to the original response structure from backend. Removed Ga…
e36b11b 
…eModels and used a Map<String,Any> instead
@Arjupta
Updating with develop
235208a
@Arjupta
Removed GaeModels from exemptions file & platform parameter from TEST…
779282d 
…_DEPS of testing module
@Arjupta
Nit change for renaming test function
0309e33
@Arjupta
Nit change for adding named arguments
8586e6f
@Arjupta
Suggested change for testing request query, new files for test constants
f59305d 
and KDoc changes
@Arjupta
Static checks and updating exemption file
c642b47
@Arjupta
Updating with develop
d354c05
@Arjupta
Basic commit for introducing a Worker, WorkerFactory and WorkerInitia…
7108509 
…lizer
@Arjupta
Including all the files related to Platform Parameter Worker.
57dfce4
@Arjupta
SyncUp worker tests are running fine. Commented out Prod Platform Par…
76515bf 
…ameter Service Impl in Network Module
@Arjupta
Added the tests for SyncUpWorkManagerInitializer
0c05d72
@Arjupta
Introduced TestNetworkModule in the tests to remove the dependency fr…
0cb44cb 
…om NetworkModule
@Arjupta
Modified exemption file to exclude Worker Factory and Module
e310e9e
@Arjupta
Added bazel dependency over PlatformParameterService and ContextExten…
9e1a428 
…sions
@Arjupta
Added NetworkModule in all the tests under where WorkManagerConfigura…
6ba3a8f 
…tionModule is used
@Arjupta
Suggested nit changes
67d8951
@Arjupta
Added tests for MockPlatformParameterService
af760fa
@Arjupta
Updating with develop
6f1efe7
@Arjupta
Updating with Base PR
39c4c0f
@Arjupta
Added test files in the kdoc-exemption
4fa3761
@Arjupta Arjupta removed their assignment Aug 20, 2021
Base automatically changed from platform-parameter-work-manager to develop August 20, 2021 21:44
@BenHenning
Copy link
Sponsor Member

@Arjupta I unfortunately didn't review this before merging the base PR, and trying to review the deltas isn't working very well. Can you please bring this up-to-date with develop & properly incorporate the base deltas so that the PR changes are correct?

@BenHenning BenHenning assigned Arjupta and unassigned BenHenning Aug 20, 2021
@Arjupta Arjupta removed the request for review from rt4914 August 21, 2021 04:44
@Arjupta
Copy link
Contributor Author

Arjupta commented Aug 21, 2021

@Arjupta I unfortunately didn't review this before merging the base PR, and trying to review the deltas isn't working very well. Can you please bring this up-to-date with develop & properly incorporate the base deltas so that the PR changes are correct?

@BenHenning I have updated the PR with develop. You can see your requested changes now

@Arjupta Arjupta assigned BenHenning and unassigned Arjupta Aug 21, 2021
@Arjupta Arjupta added this to the GSoC 2021.4: Milestone 2 milestone Aug 21, 2021
BenHenning
BenHenning reviewed Aug 21, 2021
View reviewed changes
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Arjupta. Just 2 nits otherwise the PR LGTM.

utility/src/main/java/org/oppia/android/util/platformparameter/PlatformParameterConstants.kt Outdated Show resolved Hide resolved
app/src/test/java/org/oppia/android/app/testing/PlatformParameterIntegrationTest.kt Show resolved Hide resolved
@BenHenning BenHenning assigned Arjupta and unassigned BenHenning Aug 21, 2021
@Arjupta Arjupta assigned BenHenning and unassigned Arjupta Aug 21, 2021
BenHenning
BenHenning approved these changes Aug 21, 2021
View reviewed changes
Copy link
Sponsor Member

@BenHenning BenHenning left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Arjupta. LGTM barring CI checks.

Edit: also, given that the previous run passed on Bazel checks I'm going to enable auto-merge since the deltas are just comment changes.

app/src/test/java/org/oppia/android/app/testing/PlatformParameterIntegrationTest.kt Show resolved Hide resolved
@BenHenning BenHenning enabled auto-merge (squash) August 21, 2021 09:04
@oppiabot
Copy link

oppiabot bot commented Aug 21, 2021

Unassigning @BenHenning since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label Aug 21, 2021
@oppiabot
Copy link

oppiabot bot commented Aug 21, 2021

Hi @Arjupta, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!

@BenHenning BenHenning merged commit d667cfc into develop Aug 21, 2021
@BenHenning BenHenning deleted the platform-parameter-integration-test-update branch August 21, 2021 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinitamurthi vinitamurthi vinitamurthi approved these changes

@BenHenning BenHenning BenHenning approved these changes

@anandwana001 anandwana001 anandwana001 approved these changes

@jcqli jcqli jcqli approved these changes

Assignees

@Arjupta Arjupta

Labels
PR: LGTM
Projects
No open projects
GSoC 2021.4: Feature Flags & Platform...
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include tests for SyncUp mechanism in the Integration Test for Platform Parameters
5 participants
@Arjupta @anandwana001 @BenHenning @vinitamurthi @jcqli