Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3461 : Merged App Version fragment and app version activity into individual files #3683

Merged
merged 13 commits into from
Aug 20, 2021
Merged

Fix #3461 : Merged App Version fragment and app version activity into individual files #3683

merged 13 commits into from
Aug 20, 2021

Conversation

Rohit1173
Copy link
Contributor

Explanation

Fix #3461
There were 3 files of app_version_fragment, I have and I compared them in the given website and added the specific changes in their respective dimens.xml files.
There were 2 files of app_version_activity, and both were identical so I have deleted the Landscape file
Here are the screenshots of the app before and after the above-mentioned changes

BEFORE AFTER
before-1 after-1
before-2 after-2
before-3 after-3
before-4 after-4

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@Rohit1173
Copy link
Contributor Author

@anandwana001 @rt4914 PTAL

prayutsu
prayutsu suggested changes Aug 15, 2021
View reviewed changes
Copy link
Contributor

@prayutsu prayutsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, PTAL @Rohit1173

.idea/deploymentTargetDropDown.xml Outdated Show resolved Hide resolved
.idea/misc.xml Outdated Show resolved Hide resolved
.idea/runConfigurations.xml Outdated Show resolved Hide resolved
app/src/main/res/values-land/dimens.xml Outdated Show resolved Hide resolved
@Rohit1173
Copy link
Contributor Author

@prayutsu PTAL

@oppiabot oppiabot bot assigned prayutsu and unassigned Rohit1173 Aug 15, 2021
@oppiabot
Copy link

oppiabot bot commented Aug 15, 2021

Unassigning @Rohit1173 since a re-review was requested. @Rohit1173, please make sure you have addressed all review comments. Thanks!

@prayutsu
Copy link
Contributor

@Rohit1173 You should never mark conversation resolved if you didn't initiate the comment. They should only be resolved by the reviewers.
I am marking them unresolved and will resolve them again if I find that the change has been done.

prayutsu
prayutsu approved these changes Aug 15, 2021
View reviewed changes
Copy link
Contributor

@prayutsu prayutsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @Rohit1173

@prayutsu prayutsu removed the request for review from BenHenning August 15, 2021 08:55
@Rohit1173
Copy link
Contributor Author

LGTM, Thanks @Rohit1173

@Rohit1173 You should never mark conversation resolved if you didn't initiate the comment. They should only be resolved by the reviewers.
I am marking them unresolved and will resolve them again if I find that the change has been done.

I will make sure this doesn't happen again
Thanks,

rt4914
rt4914 suggested changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rohit1173 Please take the values again it looks like the values have been used incorrectly.

app/src/main/res/layout/app_version_fragment.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/app_version_fragment.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/app_version_fragment.xml Outdated Show resolved Hide resolved
@rt4914 rt4914 assigned Rohit1173 and unassigned rt4914 Aug 16, 2021
@Rohit1173
Copy link
Contributor Author

@rt4914 PTAL

@oppiabot oppiabot bot assigned rt4914 and unassigned Rohit1173 Aug 17, 2021
@oppiabot
Copy link

oppiabot bot commented Aug 17, 2021

Unassigning @Rohit1173 since a re-review was requested. @Rohit1173, please make sure you have addressed all review comments. Thanks!

rt4914
rt4914 suggested changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rohit1173 PTAL

app/src/main/res/values-sw600dp-land/dimens.xml Show resolved Hide resolved
@rt4914 rt4914 assigned Rohit1173 and unassigned rt4914 Aug 18, 2021
@Rohit1173
Copy link
Contributor Author

@rt4914 PTAL

@oppiabot oppiabot bot assigned rt4914 and unassigned Rohit1173 Aug 19, 2021
@oppiabot
Copy link

oppiabot bot commented Aug 19, 2021

Unassigning @Rohit1173 since a re-review was requested. @Rohit1173, please make sure you have addressed all review comments. Thanks!

rt4914
rt4914 approved these changes Aug 20, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 merged commit d79449d into oppia:develop Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

@prayutsu prayutsu prayutsu approved these changes

Assignees

@rt4914 rt4914

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merge app_version_activity and app_version_fragment into individual xml file
4 participants
@Rohit1173 @prayutsu @rt4914 @anandwana001