Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3662: Complete lightweight checkpointing #3686

Merged
merged 179 commits into from
Aug 22, 2021

Conversation

MaskedCarrot
Copy link
Contributor

@MaskedCarrot MaskedCarrot commented Aug 15, 2021

Explanation

Fixes #3662

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Final Result

lightweight_checkpointing.mp4

Espresso Tests

StateFragmentTest

Screenshot from 2021-08-21 04-19-07

ExplorationActivityTest

Screenshot from 2021-08-20 03-04-28

@BenHenning
Copy link
Sponsor Member

@MaskedCarrot per my earlier comment, this isn't yet based on develop with passing CI. Please reassign at that point.

@anandwana001 anandwana001 removed their assignment Aug 22, 2021
@anandwana001
Copy link
Contributor

Assign me back once test passes on CI.

Following on this, assign me back once this PR get develop branch as base branch.

Base automatically changed from app-layer-mech-to-resume-checkpoints to develop August 22, 2021 08:32
@MaskedCarrot MaskedCarrot changed the title Fix #3662: Complete lightweight checkpointing [Blocked on #3672] Fix #3662: Complete lightweight checkpointing Aug 22, 2021
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code owner file LGTM

@oppiabot
Copy link

oppiabot bot commented Aug 22, 2021

Unassigning @anandwana001 since they have already approved the PR.

@oppiabot
Copy link

oppiabot bot commented Aug 22, 2021

Assigning @vinitamurthi for code owner reviews. Thanks!

@vinitamurthi
Copy link
Contributor

I think I was added by mistake, I dont codeown any of these files. Removing myself!

@vinitamurthi vinitamurthi removed their assignment Aug 22, 2021
@vinitamurthi vinitamurthi removed their request for review August 22, 2021 14:27
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MaskedCarrot. LGTM!

@BenHenning
Copy link
Sponsor Member

Given everyone's approved, CI is passing, and there are not outstanding conversation threads, merging this.

@BenHenning BenHenning merged commit bd4297c into develop Aug 22, 2021
@BenHenning BenHenning deleted the complete-lightweight-checkpointing branch August 22, 2021 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop marking lessons as started_not_completed once checkpointing is enabled.
6 participants