Fix #3277: Created BUILD.bazel for domain/state #3694

yash10019coder · 2021-08-17T11:55:37Z

Explanation

Fixes #3277
Created a BUILD.bazel file in domain state

Checklist

The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
The PR follows the style guide.
The PR does not contain any unnecessary auto-generated code from Android Studio.
The PR is made from a branch that's not called "develop".
The PR is made from a branch that is up-to-date with "develop".
The PR's branch is based on "develop" and not on any other branch.
The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

yash10019coder · 2021-08-17T11:56:30Z

@fsharpasharp @anandwana001 @prayutsu created a PR but unable to add dependencies in BUILD.bazel please help

…UILD.bazel file

yash10019coder · 2021-08-19T06:45:43Z

All the dependencies in the domain/utility classes are of model and it has no bazel packages for it therefore I'm haveing trouble including the dependencies of the domain/utility classes

BenHenning · 2021-08-20T22:12:23Z

@yash10019coder you'll need to add dependencies from https://github.com/oppia/oppia-android/blob/develop/model/BUILD.bazel, e.g.: //model:exploration_java_proto_lite for each of the protos that are used by these classes. I think Exploration gives you most of them, but you might need a few more.

…bazel/state in global of bazel/domain in kt_android_library

yash10019coder · 2021-08-21T04:56:26Z

@yash10019coder you'll need to add dependencies from https://github.com/oppia/oppia-android/blob/develop/model/BUILD.bazel, e.g.: //model:exploration_java_proto_lite for each of the protos that are used by these classes. I think Exploration gives you most of them, but you might need a few more.

@BenHenning I have added these dependencies in my latest commit but I still get some errors and how did you found out that we have to put this in dependencies //model:exploration_java_proto_lite three is no mention of the java files in it

and I'm attaching the screenshot of the error

prayutsu · 2021-08-21T06:56:57Z

@yash10019coder you'll need to add dependencies from https://github.com/oppia/oppia-android/blob/develop/model/BUILD.bazel, e.g.: //model:exploration_java_proto_lite for each of the protos that are used by these classes. I think Exploration gives you most of them, but you might need a few more.

@BenHenning I have added these dependencies in my latest commit but I still get some errors and how did you found out that we have to put this in dependencies //model:exploration_java_proto_lite three is no mention of the java files in it

and I'm attaching the screenshot of the error

@yash10019coder To find out what deps need to be added, you can check the imports of the file StateDeck.kt as imports tell us what other classes are we using in that file.
If you look at the error carefully, it says unresolved reference which means that Bazel does not know about those particular classes when it tries to build these newly introduces libraries. If you want to tell Bazel about these classes, then you need to add those classes in the deps as well.

prayutsu

@yash10019coder Left some comments, PTAL.

prayutsu · 2021-08-21T06:57:35Z

.idea/runConfigurations.xml

-      </set>
-    </option>
-  </component>
-</project>


Please restore this file.

It appears this file was removed again--please restore it.

prayutsu · 2021-08-21T06:58:34Z

domain/src/main/java/org/oppia/android/domain/state/BUILD.bazel

+    visibility = ["//:oppia_api_visibility"],
+    deps = [
+        "//model:exploration_java_proto_lite"
+    ]


Add all missing deps that are being highlighted in the build error.
Ditto for other added libraries.

@prayutsu that I have understood but the main problem is how to find which proto is to be added
like AnswersAndResponse.java is being used in StateDeck but now how can I find the particular of this in bazel/model

You need to find the proto file that contains the message AnswerAndResponse in it and then you can specify the library of that file here.
To find the .proto file just press Ctrl + Shift + R and type the keywords that you want to search in the whole codebase.

prayutsu

@yash10019coder Followed up on our comment.

prayutsu · 2021-08-21T08:17:57Z

domain/src/main/java/org/oppia/android/domain/state/BUILD.bazel

+    visibility = ["//:oppia_api_visibility"],
+    deps = [
+        "//model:exploration_java_proto_lite"
+    ]


You need to find the proto file that contains the message AnswerAndResponse in it and then you can specify the library of that file here.
To find the .proto file just press Ctrl + Shift + R and type the keywords that you want to search in the whole codebase.

…some java_proto_lite in bazel/model

yash10019coder · 2021-08-22T04:48:28Z

@prayutsu @fsharpasharp made a new commit PTAL
I'm still getting errors althought I have added all the dependencies
attaching the SS below

oppiabot · 2021-08-22T04:51:32Z

Unassigning @yash10019coder since a re-review was requested. @yash10019coder, please make sure you have addressed all review comments. Thanks!

Also removed the internal keyword from StateDeck.kt StateGraph.kt and StateList.kt

yash10019coder

@BenHenning resolved the comments

domain/src/main/java/org/oppia/android/domain/state/StateDeck.kt

yash10019coder · 2021-09-21T12:08:36Z

@BenHenning PTAL

oppiabot · 2021-09-21T12:11:39Z

Unassigning @yash10019coder since a re-review was requested. @yash10019coder, please make sure you have addressed all review comments. Thanks!

BenHenning

Thanks @yash10019coder. Just 2 new comments.

Similar to my comment in your other PR, please make sure to respond via a comment to all conversation threads from reviewers to confirm you saw them & addressed/didn't address them.

domain/src/main/java/org/oppia/android/domain/state/StateDeck.kt

domain/src/main/java/org/oppia/android/domain/state/BUILD.bazel

BenHenning

Thanks @yash10019coder. Justhad one follow-up.

domain/src/main/java/org/oppia/android/domain/state/BUILD.bazel

…9coder/oppia-android into create-build-bazel-domain-state

yash10019coder · 2021-10-03T09:40:51Z

@BenHenning removed unused and unncesscarty imports from the bazel build file PTAL

Added some deps in glob due to failing tests these changes happened due to merge conflict

BenHenning

Thanks @yash10019coder. This LGTM!

BenHenning · 2021-10-05T03:56:49Z

@prayutsu it seems you requested changes. Could you PTAL?

prayutsu

LGTM, Thanks @yash10019coder

prayutsu · 2021-10-05T06:57:55Z

@BenHenning This is ready to merge now 😄

BenHenning · 2021-10-06T02:28:38Z

Thanks @prayutsu & @yash10019coder.

Created BUILD.bazel for domain/state

f1fa2b8

yash10019coder requested a review from BenHenning as a code owner August 17, 2021 11:55

yash10019coder added 2 commits August 17, 2021 17:32

updated BUILD.bazel

f5caabf

Added the directory to the MIGRATED_PROD_FILES of the module's root B…

fb4ac92

…UILD.bazel file

yash10019coder assigned fsharpasharp Aug 18, 2021

BenHenning assigned BenHenning and unassigned fsharpasharp Aug 19, 2021

BenHenning assigned yash10019coder and unassigned BenHenning Aug 20, 2021

Added dependencies in bazel/state file and added dependencies of the …

e9c725f

…bazel/state in global of bazel/domain in kt_android_library

prayutsu suggested changes Aug 21, 2021

View reviewed changes

yash10019coder assigned BenHenning and fsharpasharp Aug 21, 2021

Added runConfigurations.xml file

e059a7f

prayutsu reviewed Aug 21, 2021

View reviewed changes

prayutsu unassigned BenHenning and fsharpasharp Aug 21, 2021

Added all the dependencies in bazel/state and added api visiblity to …

8b0f615

…some java_proto_lite in bazel/model

oppiabot bot assigned fsharpasharp and prayutsu and unassigned yash10019coder Aug 22, 2021

yash10019coder added 2 commits August 22, 2021 12:41

reverted bazel/model

acac129

Fixed all the errors now bazel/state file successfully builds

5ef42e2

Also removed the internal keyword from StateDeck.kt StateGraph.kt and StateList.kt

yash10019coder commented Sep 21, 2021

View reviewed changes

domain/src/main/java/org/oppia/android/domain/state/StateDeck.kt Show resolved Hide resolved

domain/src/main/java/org/oppia/android/domain/state/StateDeck.kt Outdated Show resolved Hide resolved

domain/src/main/java/org/oppia/android/domain/state/StateDeck.kt Outdated Show resolved Hide resolved

oppiabot bot assigned BenHenning and unassigned yash10019coder Sep 21, 2021

BenHenning reviewed Sep 22, 2021

View reviewed changes

domain/src/main/java/org/oppia/android/domain/state/StateDeck.kt Outdated Show resolved Hide resolved

domain/src/main/java/org/oppia/android/domain/state/BUILD.bazel Outdated Show resolved Hide resolved

BenHenning assigned yash10019coder and unassigned BenHenning Sep 22, 2021

yash10019coder requested a review from BenHenning September 28, 2021 11:48

yash10019coder assigned BenHenning Sep 28, 2021

Merge branch 'develop' into create-build-bazel-domain-state

05700b7

BenHenning reviewed Sep 29, 2021

View reviewed changes

domain/src/main/java/org/oppia/android/domain/state/BUILD.bazel Outdated Show resolved Hide resolved

BenHenning removed their assignment Sep 29, 2021

yash10019coder added 2 commits October 3, 2021 15:08

removed unused and unnecessary dependencies

6662500

Merge branch 'create-build-bazel-domain-state' of github.com:yash1001…

d46572e

…9coder/oppia-android into create-build-bazel-domain-state

yash10019coder assigned BenHenning and unassigned yash10019coder Oct 3, 2021

Update BUILD.bazel

aa5a806

Added some deps in glob due to failing tests these changes happened due to merge conflict

BenHenning approved these changes Oct 5, 2021

View reviewed changes

BenHenning assigned prayutsu and unassigned BenHenning Oct 5, 2021

prayutsu approved these changes Oct 5, 2021

View reviewed changes

prayutsu assigned BenHenning and unassigned prayutsu Oct 5, 2021

oppiabot bot added the PR: LGTM label Oct 5, 2021

BenHenning merged commit 25a7670 into oppia:develop Oct 6, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #3277: Created BUILD.bazel for domain/state #3694

Fix #3277: Created BUILD.bazel for domain/state #3694

yash10019coder commented Aug 17, 2021 •

edited

yash10019coder commented Aug 17, 2021 •

edited

yash10019coder commented Aug 19, 2021

BenHenning commented Aug 20, 2021

yash10019coder commented Aug 21, 2021

prayutsu commented Aug 21, 2021

prayutsu left a comment

prayutsu Aug 21, 2021

BenHenning Aug 24, 2021

prayutsu Aug 21, 2021

yash10019coder Aug 21, 2021

prayutsu Aug 21, 2021

prayutsu left a comment

prayutsu Aug 21, 2021

yash10019coder commented Aug 22, 2021

oppiabot bot commented Aug 22, 2021

yash10019coder left a comment

yash10019coder commented Sep 21, 2021

oppiabot bot commented Sep 21, 2021

BenHenning left a comment

BenHenning left a comment

yash10019coder commented Oct 3, 2021

BenHenning left a comment

BenHenning commented Oct 5, 2021

prayutsu left a comment

prayutsu commented Oct 5, 2021

BenHenning commented Oct 6, 2021

Fix #3277: Created BUILD.bazel for domain/state #3694

Fix #3277: Created BUILD.bazel for domain/state #3694

Conversation

yash10019coder commented Aug 17, 2021 • edited

Explanation

Checklist

yash10019coder commented Aug 17, 2021 • edited

yash10019coder commented Aug 19, 2021

BenHenning commented Aug 20, 2021

yash10019coder commented Aug 21, 2021

prayutsu commented Aug 21, 2021

prayutsu left a comment

Choose a reason for hiding this comment

prayutsu Aug 21, 2021

Choose a reason for hiding this comment

BenHenning Aug 24, 2021

Choose a reason for hiding this comment

prayutsu Aug 21, 2021

Choose a reason for hiding this comment

yash10019coder Aug 21, 2021

Choose a reason for hiding this comment

prayutsu Aug 21, 2021

Choose a reason for hiding this comment

prayutsu left a comment

Choose a reason for hiding this comment

prayutsu Aug 21, 2021

Choose a reason for hiding this comment

yash10019coder commented Aug 22, 2021

oppiabot bot commented Aug 22, 2021

yash10019coder left a comment

Choose a reason for hiding this comment

yash10019coder commented Sep 21, 2021

oppiabot bot commented Sep 21, 2021

BenHenning left a comment

Choose a reason for hiding this comment

BenHenning left a comment

Choose a reason for hiding this comment

yash10019coder commented Oct 3, 2021

BenHenning left a comment

Choose a reason for hiding this comment

BenHenning commented Oct 5, 2021

prayutsu left a comment

Choose a reason for hiding this comment

prayutsu commented Oct 5, 2021

BenHenning commented Oct 6, 2021

yash10019coder commented Aug 17, 2021 •

edited

yash10019coder commented Aug 17, 2021 •

edited