-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3396 and #3397: Implement Show All Hints and Solution Feature #3705
Conversation
…nto move-hint-handler-to-domain
…o move-hint-handler-to-domain
Yes. I just saw that the test was failing. It was due to the change in |
Unassigning @yashraj-01 since a re-review was requested. @yashraj-01, please make sure you have addressed all review comments. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not codeowner but reviewed my last test function name suggestion.
Thanks @anandwana001. Unassigning you now. |
This test was failing even when I re-ran the tests. I don't think this PR affects this test. |
There was another failure on Bazel |
This passed after re-running. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yashraj-01. Latest PR LGTM, but it seems there are still CI failures (possibly due to #3714). Could you resolve my last comment & see if a new run fixes CI? Happy to approve once CI is green.
domain/src/test/java/org/oppia/android/domain/hintsandsolution/HintHandlerDebugImplTest.kt
Show resolved
Hide resolved
...n/src/test/java/org/oppia/android/domain/hintsandsolution/HintsAndSolutionDebugModuleTest.kt
Show resolved
Hide resolved
domain/src/main/java/org/oppia/android/domain/hintsandsolution/HintHandlerDebugImpl.kt
Outdated
Show resolved
Hide resolved
The CI checks have passed except the failing PlatformParameter test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yashraj-01. LGTM. Re-running the Gradle test to see if it'll pass this time.
Unassigning @BenHenning since they have already approved the PR. |
Explanation
Fixes #3396.
Fixes #3397.
Implemented feature to show all hints and solution.
Screenshots
Untitled.mp4
Untitled.1.mp4
DeveloperOptionsFragmentTest
Checklist