Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3662: Remove TODO for not marking lessons started_not_completed. #3717

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Fix #3662: Remove TODO for not marking lessons started_not_completed. #3717

merged 1 commit into from
Aug 23, 2021

Conversation

MaskedCarrot
Copy link
Contributor

@MaskedCarrot MaskedCarrot commented Aug 22, 2021 •
edited

Explanation

Fixes #3662

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@aggarwalpulkit596 aggarwalpulkit596 enabled auto-merge (squash) August 23, 2021 02:51
@aggarwalpulkit596 aggarwalpulkit596 enabled auto-merge (squash) August 23, 2021 02:51
anandwana001
anandwana001 approved these changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

Please fix the PR title, there is a typo.

@MaskedCarrot MaskedCarrot changed the title Fix #3662: remvoe todo for not marking lessons started_not_completed. Fix #3662: Remove TODO for not marking lessons started_not_completed. Aug 23, 2021
@oppiabot
Copy link

oppiabot bot commented Aug 23, 2021

Unassigning @anandwana001 since they have already approved the PR.

BenHenning
BenHenning approved these changes Aug 23, 2021
View reviewed changes
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MaskedCarrot. LGTM

@aggarwalpulkit596 aggarwalpulkit596 merged commit 04f39a6 into develop Aug 23, 2021
@aggarwalpulkit596 aggarwalpulkit596 deleted the remove-todo branch August 23, 2021 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenHenning BenHenning BenHenning approved these changes

@anandwana001 anandwana001 anandwana001 approved these changes

@aggarwalpulkit596 aggarwalpulkit596 aggarwalpulkit596 approved these changes

Assignees

@BenHenning BenHenning

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stop marking lessons as started_not_completed once checkpointing is enabled.
4 participants
@MaskedCarrot @BenHenning @anandwana001 @aggarwalpulkit596