Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3530: Merge home fragments #3737

Merged
merged 6 commits into from
Aug 30, 2021
Merged

Conversation

bkaur-bkj
Copy link
Contributor

Explanation

Fixes #6447
Merged the 4 home-fragment xmls (landscape/portrait of phone and tablet )into one home- fragment
Have added screenshots of home-fragment before and after changes in android phone. Sorry could not attach screenshots for tablet as emulator was not being supported by my studio.
Before changes

WhatsApp Image 2021-08-25 at 9 27 53 PM (1)

WhatsApp Image 2021-08-25 at 9 27 53 PM

After changes

WhatsApp Image 2021-08-25 at 9 29 56 PM

WhatsApp Image 2021-08-25 at 9 29 52 PM

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@bkaur-bkj
Copy link
Contributor Author

@rt4914 pls take a look

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bkaur-bkj PTAL

.idea/misc.xml Outdated Show resolved Hide resolved
.idea/runConfigurations.xml Outdated Show resolved Hide resolved
app/src/main/res/values-land/dimens.xml Outdated Show resolved Hide resolved
app/src/main/res/values-sw600dp-land/dimens.xml Outdated Show resolved Hide resolved
@rt4914 rt4914 assigned bkaur-bkj and unassigned rt4914 Aug 28, 2021
@bkaur-bkj bkaur-bkj removed their assignment Aug 28, 2021
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 merged commit fc2e4ba into oppia:develop Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants