Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3571: Merged recently-played-fragment #3770

Merged
merged 3 commits into from
Sep 28, 2021
Merged

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Sep 7, 2021

Explanation

Fix #3571: Merged recently-played-fragment

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

I haven't added any screenshots as there is only padding_top and padding_bottom difference between in all the layout files. Rest all is exactly same.

@anandwana001
Copy link
Contributor

Some tests are failing.

@anandwana001 anandwana001 assigned rt4914 and unassigned anandwana001 Sep 8, 2021
@rt4914 rt4914 assigned anandwana001 and unassigned rt4914 Sep 14, 2021
@rt4914
Copy link
Contributor Author

rt4914 commented Sep 14, 2021

@anandwana001 Merging with latest develop has solved the issues.

@oppiabot
Copy link

oppiabot bot commented Sep 21, 2021

Hi @rt4914, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 3 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Sep 21, 2021
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Sep 27, 2021
@anandwana001 anandwana001 assigned rt4914 and unassigned anandwana001 Sep 27, 2021
@oppiabot oppiabot bot added the PR: LGTM label Sep 27, 2021
@rt4914 rt4914 merged commit 7ff1b2b into develop Sep 28, 2021
@rt4914 rt4914 deleted the merge-recently-played branch September 28, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge recently_played_fragment.xml into single xml file
2 participants