Fix #3780: [RTL] Image region selection.

[veena14cs]

Explanation

Fix #3780. This PR fixes Image region selection issues in RTL layouts when tapping around the image.

Screenshot LTR and RTL

Mobile:
........

.......

Screenshot for Tests that pass in Expresso after RTL code.

Screenshot for Tests that fail in Expresso before RTL code.

Note: Not tested on Roboelectric added a todo comment in the test.

Essential Checklist

• The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• Any changes to scripts/assets files have their rationale included in the PR explanation.
• The PR follows the style guide.
• The PR does not contain any unnecessary code changes from Android Studio (reference).
• The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
• The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

• Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
• For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
• Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
• Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

[rt4914]

LGTM.

For tests I will defer to @anandwana001 Thanks.

[BenHenning]

Thanks @veena14cs! LGTM though I think we can & should re-enable the tests. See my comment.

[BenHenning]

Actually, given this can we use OppiaTestRule and RunOn(TestPlatform.ESPRESSO) here instead of ignoring? We don't actually need to ignore tests failing for specific platforms anymore.

[veena14cs]

Thanks @veena14cs! LGTM though I think we can & should re-enable the tests. See my comment.

Thanks @BenHenning I have re-enabled tests and updated screenshots in the PR description.
One test was ignored that is to be moved to Roboelectric as per the message.

[anandwana001]

You had to set the oppia test rule, else the RunOn annotation will not work.

  @get:Rule
  val oppiaTestRule = OppiaTestRule()

[anandwana001]

HelpFragmentTest for reference

[veena14cs]

I tested it without this Rule and I I wonder how it worked. Added it now it shouldn't break anywhere. Thanks for reference.

[BenHenning]

LGTM from code perspective other than the issue @anandwana001 mentioned.

@anandwana001 deferring to you to verify CI is fully passing before merging.

Thanks for quick fix @veena14cs.

[veena14cs]

LGTM from code perspective other than the issue @anandwana001 mentioned.

@anandwana001 deferring to you to verify CI is fully passing before merging.

Thanks for quick fix @veena14cs.

Thanks @BenHenning.

[anandwana001]

Assign me once finalize. LGTM for merge.

[anandwana001]

LGTM

[veena14cs]

Assign me once finalize. LGTM for merge.

Thanks :)