Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bug report to include app version #3819

Merged
merged 2 commits into from
Sep 21, 2021
Merged

Update bug report to include app version #3819

merged 2 commits into from
Sep 21, 2021

Conversation

BenHenning
Copy link
Sponsor Member

@BenHenning BenHenning commented Sep 20, 2021 •
edited

Explanation

Add app version to bug report & refine a few other aspects of the template.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

N/A

@BenHenning
Update bug report to include app version
f4db636 
Add app version to bug report & refine a few other aspects of the template.
@BenHenning BenHenning marked this pull request as ready for review September 20, 2021 16:39
@BenHenning
Copy link
Sponsor Member Author

/cc @srushtirk

@BenHenning
Update bug_report.md
867ff2a 
Indicate how the environment questions should be filled in.
anandwana001
anandwana001 approved these changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This gives a feeling that we can scaling now 🎉 🎊🎊🎉🥳

@oppiabot oppiabot bot added the PR: LGTM label Sep 20, 2021
@oppiabot
Copy link

oppiabot bot commented Sep 20, 2021

Hi @BenHenning, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!

@BenHenning
Copy link
Sponsor Member Author

Thanks @anandwana001!

@BenHenning BenHenning merged commit f239f36 into develop Sep 21, 2021
@BenHenning BenHenning deleted the update-bug-report-template branch September 21, 2021 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandwana001 anandwana001 anandwana001 approved these changes

Assignees

@BenHenning BenHenning

Labels
PR: LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BenHenning @anandwana001