Fix #1390: Show terms of service & privacy policy notices. #3852

veena14cs · 2021-09-28T09:22:08Z

Explanation

This PR fixes #1390. This PR introduces Privacy Policy and Terms of Service in the app. The PR contains Policies page through onboarding flow and FAQ/Help screens.

This PR also fixes #1022. This PR introduces two new custom tags <oppia-ul> and <oppia-ol> to support html <ul> and <ol> tags respectively. To addon the new custom list tags also supports lower versions devices and nested list tags.

This PR also fixes #2193 RTL issues in Bullet points and fixes the crashes in the issue #2391

Mock Links

Onboarding
Mobile Landscape
Tablet
FAQ and Help
Mobile Landscape
Tablet

Document Reference

https://docs.google.com/document/d/1QoW2S-HGNrQ_6rodOByjGPd8e_w80PHKE3PJ82t1-hE/edit?usp=sharing

Screenshots

Mobile Portrait on Nexus 6

..............

.....

......

....

.....

Tablet :

....

.........

.....

Screenshots on Mdpi device

....
......
...

LTR and RTL list Tablet

......
....

...
....

LTR Video

Screenrecording_20220309_155903.mp4

RTL Video

Screenrecording_20220804_111917.mp4

Essential Checklist

The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
Any changes to scripts/assets files have their rationale included in the PR explanation.
The PR follows the style guide.
The PR does not contain any unnecessary code changes from Android Studio (reference).
The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
The PR is assigned to the appropriate reviewers (reference).

Known Issues

New custom List tag doesn't support RTL

BenHenning · 2021-10-05T03:51:36Z

@veena14cs I left feedback in chat. Please assign back or ping me if there's anything else you need my thoughts on.

veena14cs · 2021-10-05T05:21:41Z

@veena14cs I left feedback in chat. Please assign back or ping me if there's anything else you need my thoughts on.

Thanks @BenHenning .

oppiabot · 2021-10-13T11:21:01Z

Hi @veena14cs, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

BenHenning · 2021-10-21T05:56:02Z

Thanks @veena14cs! I think I'll need to take a look at this tomorrow my time, but in the meantime:

Can you add screenshots for landscape for all the mocks currently in the opening comment to show how landscape works? Ditto for tablet portrait + landscape.
We need to include links to the web copies of the policies. Are these included? Can you maybe include a video showing navigating to each policy & clicking on the links?
Can you please add a video showing the TalkBack experience for each screen?
CI has failures--can you make sure that these are fixed?

BenHenning · 2021-10-22T08:34:17Z

Sorry, will need to review this next week. Given that, @veena14cs can you please address all the points in #3852 (comment) & assign back one done?

veena14cs · 2021-10-22T19:07:57Z

Thanks @veena14cs! I think I'll need to take a look at this tomorrow my time, but in the meantime:

Can you add screenshots for landscape for all the mocks currently in the opening comment to show how landscape works? Ditto for tablet portrait + landscape.

We need to include links to the web copies of the policies. Are these included? Can you maybe include a video showing navigating to each policy & clicking on the links?

Can you please add a video showing the TalkBack experience for each screen?

CI has failures--can you make sure that these are fixed?

1- Mobile-landscape and tablet portrait + landscape mocks are not yet provided. I have included landscape screenshots though.
2- I have added link at the bottom of the page for both PP/Tos PTAL in the video.
3- I will have to check on this still.
4- Waiting for the tests to complete.

veena14cs · 2021-10-22T19:09:40Z

Sorry, will need to review this next week. Given that, @veena14cs can you please address all the points in #3852 (comment) & assign back one done?

Thanks for the update @BenHenning . Can you please look at the video once and confirm if its correct. I have added web link for PP/Tos on the Privacy policy and Terms of service page.

rt4914

@veena14cs I have left comments on overall approach PTAL

app/src/main/java/org/oppia/android/app/help/HelpActivity.kt

app/src/main/java/org/oppia/android/app/onboarding/OnboardingFragmentPresenter.kt

...va/org/oppia/android/app/privacypolicytermsofservice/PrivacyPolicySingleActivityPresenter.kt

app/src/main/res/layout-land/onboarding_slide_final.xml

app/src/main/res/layout/privacy_policy_single_activity.xml

app/src/main/res/values/privacy_policy.xml

BenHenning · 2021-10-26T05:08:57Z

Sorry, will need to review this next week. Given that, @veena14cs can you please address all the points in #3852 (comment) & assign back one done?

Thanks for the update @BenHenning . Can you please look at the video once and confirm if its correct. I have added web link for PP/Tos on the Privacy policy and Terms of service page.

@veena14cs the videos are flickering really badly and it's making it difficult to evaluate. Can you maybe try to re-record them or check with someone else to see if it works for them? It may be specific to my computer, but I haven't had this issue with other uploaded videos.

Beyond that, I plan to look at this PR in more depth tomorrow.

BenHenning

Thanks @veena14cs. Took a first pass on nearly everything (skipped verifying the policy text for now, the new html utility, and tests).

My main feedback is that I think we should introduce just a single activity/fragment + presenters for both policies and make them generic. It seems both are basically identical, so the extra boilerplate seems unnecessary. Sharing them will reduce the overall surface being introduced here.

app/build.gradle

app/src/main/AndroidManifest.xml

app/src/main/java/org/oppia/android/app/help/HelpActivityPresenter.kt

app/BUILD.bazel

app/src/main/java/org/oppia/android/app/help/HelpActivityPresenter.kt

app/src/main/res/layout/privacy_policy_fragment.xml

app/src/main/res/values/strings.xml

veena14cs · 2022-08-22T19:44:07Z

@BenHenning I have fixed testcases related to canvas. PTAL.

BenHenning

Thanks @veena14cs! Just had 4 small remaining comments, otherwise the PR LGTM!

app/src/sharedTest/java/org/oppia/android/app/parser/ListItemLeadingMarginSpanTest.kt

BenHenning

Thanks @veena14cs. Just a couple more follow-up comments--PTAL.

app/src/sharedTest/java/org/oppia/android/app/parser/ListItemLeadingMarginSpanTest.kt

veena14cs · 2022-08-25T05:41:57Z

Thanks @veena14cs. Just a couple more follow-up comments--PTAL.

I have addressed and fixed the comments. PTAL.

BenHenning · 2022-08-25T05:58:26Z

Thanks @veena14cs! I have no further comments, so I think we're mainly waiting on CI.

BenHenning

Thanks @veena14cs! Everything here LGTM! This was a set of gnarly problems, and it's really nice to see all of this come together.

veena14cs requested review from BenHenning and rt4914 as code owners September 28, 2021 09:22

veena14cs assigned BenHenning Oct 2, 2021

BenHenning assigned veena14cs and unassigned BenHenning Oct 5, 2021

veena14cs marked this pull request as draft October 5, 2021 05:23

oppiabot bot added stale Corresponds to items that haven't seen a recent update and may be automatically closed. and removed stale Corresponds to items that haven't seen a recent update and may be automatically closed. labels Oct 13, 2021

veena14cs changed the title ~~Fix #1390,#1391: Show terms of service & privacy policy notices [WIP]~~ Fix #1390,#1391: Show terms of service & privacy policy notices. Oct 18, 2021

veena14cs marked this pull request as ready for review October 18, 2021 19:18

veena14cs assigned rt4914 and BenHenning and unassigned veena14cs Oct 20, 2021

BenHenning assigned veena14cs Oct 21, 2021

BenHenning removed their assignment Oct 22, 2021

rt4914 suggested changes Oct 22, 2021

View reviewed changes

rt4914 removed their assignment Oct 22, 2021

veena14cs requested a review from rt4914 October 25, 2021 19:49

veena14cs assigned rt4914 and BenHenning and unassigned veena14cs Oct 25, 2021

BenHenning requested changes Oct 27, 2021

View reviewed changes

veena14cs added 2 commits August 23, 2022 01:08

Merge remote-tracking branch 'upstream/develop' into develop

0385064

Merge branch 'develop' into privacy-policy

633416f

BenHenning reviewed Aug 24, 2022

View reviewed changes

BenHenning assigned veena14cs and unassigned BenHenning Aug 24, 2022

veena14cs added 4 commits August 24, 2022 19:04

Update ListItemLeadingMarginSpanTest.kt

6babf8a

Update ListItemLeadingMarginSpanTest.kt

8876ab1

Merge remote-tracking branch 'upstream/develop' into develop

61bd607

Merge branch 'develop' into privacy-policy

37fd5e8

veena14cs requested a review from BenHenning August 24, 2022 14:10

veena14cs assigned BenHenning and unassigned veena14cs Aug 24, 2022

veena14cs changed the title ~~Fix #1390, #1391: Show terms of service & privacy policy notices.~~ Fix #1390: Show terms of service & privacy policy notices. Aug 24, 2022

BenHenning reviewed Aug 25, 2022

View reviewed changes

app/src/sharedTest/java/org/oppia/android/app/parser/ListItemLeadingMarginSpanTest.kt Show resolved Hide resolved

app/src/sharedTest/java/org/oppia/android/app/parser/ListItemLeadingMarginSpanTest.kt Outdated Show resolved Hide resolved

BenHenning assigned veena14cs and unassigned BenHenning Aug 25, 2022

veena14cs added 3 commits August 25, 2022 11:04

Update ListItemLeadingMarginSpanTest.kt

5eb690f

Merge remote-tracking branch 'upstream/develop' into develop

a62d834

Merge branch 'develop' into privacy-policy

5bd7392

veena14cs requested a review from BenHenning August 25, 2022 05:39

veena14cs assigned BenHenning and unassigned veena14cs Aug 25, 2022

BenHenning approved these changes Aug 26, 2022

View reviewed changes

BenHenning merged commit 1ca0a4a into oppia:develop Aug 26, 2022

veena14cs deleted the privacy-policy branch August 26, 2022 07:37

BenHenning mentioned this pull request Nov 2, 2022

Uneven spacing between the options #3123

Closed

seanlip mentioned this pull request Jun 9, 2023

[BUG]: Bullet lists aren't showing in FAQs for all non-English languages #5034

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #1390: Show terms of service & privacy policy notices. #3852

Fix #1390: Show terms of service & privacy policy notices. #3852

veena14cs commented Sep 28, 2021 •

edited

BenHenning commented Oct 5, 2021

veena14cs commented Oct 5, 2021

oppiabot bot commented Oct 13, 2021

BenHenning commented Oct 21, 2021

BenHenning commented Oct 22, 2021

veena14cs commented Oct 22, 2021

veena14cs commented Oct 22, 2021

rt4914 left a comment

BenHenning commented Oct 26, 2021

BenHenning left a comment

veena14cs commented Aug 22, 2022

BenHenning left a comment

BenHenning left a comment

veena14cs commented Aug 25, 2022

BenHenning commented Aug 25, 2022

BenHenning left a comment

Fix #1390: Show terms of service & privacy policy notices. #3852

Fix #1390: Show terms of service & privacy policy notices. #3852

Conversation

veena14cs commented Sep 28, 2021 • edited

Explanation

Mock Links

Document Reference

Screenshots

Essential Checklist

Known Issues

BenHenning commented Oct 5, 2021

veena14cs commented Oct 5, 2021

oppiabot bot commented Oct 13, 2021

BenHenning commented Oct 21, 2021

BenHenning commented Oct 22, 2021

veena14cs commented Oct 22, 2021

veena14cs commented Oct 22, 2021

rt4914 left a comment

Choose a reason for hiding this comment

BenHenning commented Oct 26, 2021

BenHenning left a comment

Choose a reason for hiding this comment

veena14cs commented Aug 22, 2022

BenHenning left a comment

Choose a reason for hiding this comment

BenHenning left a comment

Choose a reason for hiding this comment

veena14cs commented Aug 25, 2022

BenHenning commented Aug 25, 2022

BenHenning left a comment

Choose a reason for hiding this comment

veena14cs commented Sep 28, 2021 •

edited