-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #3826 : Resolved black square that was being displayed around the profile picture #3862
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anandwana001 please let me know if this looks good, and I can approve.
@coder2699 could you please add some screenshots showing this is fixed? |
@anandwana001 I have already added the working video in the description (https://drive.google.com/file/d/12Wn486QD0Bi4qXBr6y7MzW5W8LSDz-6u/view?usp=sharing) |
Deferring to @rt4914 as he is the codeowner here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
@coder2699 Just merge with latest develop and also reformat the files. |
@rt4914 sure, I will make the changes and let you know |
…into edit-profile-pic-box � Conflicts: � app/src/main/res/layout-sw600dp-port/profile_progress_header.xml
@rt4914 @srushtirk One test case is failing, can any of you help me regarding it. |
@coder2699 check the suggestions in the failed test case
|
@rt4914 PTAL |
Hi @coder2699, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Explanation
Fixes #3826 : Adding "whiteLight" background to circular image view in "profile_progress_header.xml" file solves the existing bug.
Checkout the video: https://drive.google.com/file/d/12Wn486QD0Bi4qXBr6y7MzW5W8LSDz-6u/view?usp=sharing
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: