Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3826 : Resolved black square that was being displayed around the profile picture #3862

Merged
merged 5 commits into from
Oct 31, 2021
Merged

Fixes #3826 : Resolved black square that was being displayed around the profile picture #3862

merged 5 commits into from
Oct 31, 2021

Conversation

coder2699
Copy link
Contributor

Explanation

Fixes #3826 : Adding "whiteLight" background to circular image view in "profile_progress_header.xml" file solves the existing bug.
Checkout the video: https://drive.google.com/file/d/12Wn486QD0Bi4qXBr6y7MzW5W8LSDz-6u/view?usp=sharing

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

Copy link

@srushtirk srushtirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anandwana001 please let me know if this looks good, and I can approve.

@anandwana001
Copy link
Contributor

@coder2699 could you please add some screenshots showing this is fixed?

@coder2699
Copy link
Contributor Author

@coder2699 could you please add some screenshots showing this is fixed?

@anandwana001 I have already added the working video in the description (https://drive.google.com/file/d/12Wn486QD0Bi4qXBr6y7MzW5W8LSDz-6u/view?usp=sharing)

Here are few screenshots regarding the same:-

@coder2699 coder2699 assigned anandwana001 and unassigned coder2699 and srushtirk Oct 13, 2021
@anandwana001 anandwana001 assigned rt4914 and unassigned anandwana001 Oct 15, 2021
@anandwana001
Copy link
Contributor

Deferring to @rt4914 as he is the codeowner here.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914
Copy link
Contributor

rt4914 commented Oct 16, 2021

@coder2699 Just merge with latest develop and also reformat the files.
Press Control + Alt + L - reformatting shortcut to fix the formatting.

@rt4914 rt4914 assigned coder2699 and unassigned rt4914 Oct 16, 2021
@coder2699
Copy link
Contributor Author

@coder2699 Just merge with latest develop and also reformat the files. Press Control + Alt + L - reformatting shortcut to fix the formatting.

@rt4914 sure, I will make the changes and let you know

coder2699 added 2 commits October 20, 2021 10:43
…into edit-profile-pic-box

� Conflicts:
�	app/src/main/res/layout-sw600dp-port/profile_progress_header.xml
@coder2699
Copy link
Contributor Author

@rt4914 @srushtirk One test case is failing, can any of you help me regarding it.

@FareesHussain
Copy link
Contributor

@coder2699 check the suggestions in the failed test case
i.e,

app/src/main/res/layout-sw600dp-port/profile_progress_header.xml:45: Use start/end versions of layout properties, instead, for proper RTL support
app/src/main/res/layout-sw600dp-port/profile_progress_header.xml:42: Drawable start/end/top/bottom & image source should use the compat versions, instead, e.g.: app:drawableStartCompat or app:srcCompat, to ensure that vector drawables can load properly in SDK <21 environments.
Refer to https://github.com/oppia/oppia-android/wiki/Static-Analysis-Checks#regexpatternvalidation-check for more details on how to fix this.

@coder2699
Copy link
Contributor Author

@rt4914 PTAL

@oppiabot
Copy link

oppiabot bot commented Oct 30, 2021

Hi @coder2699, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Oct 30, 2021
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Oct 31, 2021
@rt4914 rt4914 merged commit 0bda1ed into oppia:develop Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Black square around the profile picture
5 participants