Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Oppiabot messaging to match close policy #3909

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

BenHenning
Copy link
Sponsor Member

@BenHenning BenHenning commented Oct 7, 2021

Explanation

See #3261 (comment) for an example. The current message indicates PRs are closed after 3 days, but it's actually 7 per the configuration.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

N/A

@BenHenning BenHenning marked this pull request as ready for review October 7, 2021 00:11
@BenHenning
Copy link
Sponsor Member Author

@anandwana001 PTAL.

Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oppiabot oppiabot bot added the PR: LGTM label Oct 7, 2021
@oppiabot
Copy link

oppiabot bot commented Oct 7, 2021

Hi @BenHenning, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!

@BenHenning
Copy link
Sponsor Member Author

Thanks! I wanted to wait for my previous PR merge to finish with CI workflow since it was meant to stabilize. Fortunately, it passed so this is another trial to ensure things are working better now.

@BenHenning BenHenning merged commit 63ef676 into develop Oct 7, 2021
@BenHenning BenHenning deleted the update-oppiabot-stale-messaging branch October 7, 2021 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants