-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #4012 : Renaming all colors in colors.xml with correct naming conventions. #4021
Conversation
<color name="oppiaPrimaryLight">#009688</color> | ||
<color name="oppiaPrimaryText30">#4D333333</color> | ||
<color name="oppiaPrimaryTextDark">#DE000000</color> | ||
<color name="oppiaPrimaryDark">#00645C</color> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed oppiaPrimaryDark
and renamed all its usage to oppia_primary
(previously colorPrimary
) as it was re-declaration for same color code.
Same for navigationGeneralBackground
.
@rt4914 @anandwana001 PTAL. |
I will be able to take a look at this on weekend. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my codeowners files, LGTM
Unassigning @anandwana001 since they have already approved the PR. |
color_defs.xml LGTM for snake_case changes & replacing colors.xml. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
Explanation
Fixes #4012
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: