Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4012 : Renaming all colors in colors.xml with correct naming conventions. #4021

Merged
merged 8 commits into from
Dec 8, 2021

Conversation

ayush0402
Copy link
Contributor

Explanation

Fixes #4012

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

<color name="oppiaPrimaryLight">#009688</color>
<color name="oppiaPrimaryText30">#4D333333</color>
<color name="oppiaPrimaryTextDark">#DE000000</color>
<color name="oppiaPrimaryDark">#00645C</color>
Copy link
Contributor Author

@ayush0402 ayush0402 Dec 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed oppiaPrimaryDark and renamed all its usage to oppia_primary(previously colorPrimary) as it was re-declaration for same color code.
Same for navigationGeneralBackground.

@ayush0402
Copy link
Contributor Author

@rt4914 @anandwana001 PTAL.

@anandwana001
Copy link
Contributor

I will be able to take a look at this on weekend.

Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my codeowners files, LGTM

@oppiabot
Copy link

oppiabot bot commented Dec 6, 2021

Unassigning @anandwana001 since they have already approved the PR.

@BenHenning
Copy link
Sponsor Member

color_defs.xml LGTM for snake_case changes & replacing colors.xml.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 merged commit 4b0797f into oppia:develop Dec 8, 2021
@ayush0402 ayush0402 deleted the renaming-colors branch February 10, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename all colors in colors.xml with correct naming conventions.
4 participants