Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable workflow cancellation for merged PRs #4043

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Disable workflow cancellation for merged PRs #4043

merged 1 commit into from
Jan 17, 2022

Conversation

BenHenning
Copy link
Sponsor Member

@BenHenning BenHenning commented Dec 14, 2021 •
edited

Explanation

This PR disables workflow cancellation for merged PRs to avoid past workflows failing due to being cancelled (see https://github.com/oppia/oppia-android/commits/develop). While this will slightly increase resources for subsequent PR merges, it's useful since it provides proper CI results for merged PRs (which could help isolate regressions that trigger develop CI failures that aren't caught until post-merging).

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

N/A -- CI infrastructure change

@BenHenning BenHenning marked this pull request as ready for review December 14, 2021 22:45
@BenHenning
Copy link
Sponsor Member Author

@vinitamurthi could you PTAL since this is related to developer workflow?

@BenHenning
Copy link
Sponsor Member Author

Hi. As of today, some main reviewers have taken time off for the next few weeks, so it may take a little while before we can look at this PR. We appreciate your patience while some of our team members recharge. We'll be fully returning on 4 January 2021.

@oppiabot
Copy link

oppiabot bot commented Dec 24, 2021

Hi @BenHenning, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Dec 24, 2021
@oppiabot oppiabot bot closed this Dec 31, 2021
@BenHenning BenHenning reopened this Jan 5, 2022
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jan 5, 2022
@oppiabot
Copy link

oppiabot bot commented Jan 12, 2022

Hi @BenHenning, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jan 12, 2022
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jan 13, 2022
@BenHenning
Copy link
Sponsor Member Author

@anandwana001 could you PTAL when you get a chance?

anandwana001
anandwana001 approved these changes Jan 16, 2022
View reviewed changes
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oppiabot
Copy link

oppiabot bot commented Jan 16, 2022

Unassigning @anandwana001 since they have already approved the PR.

@vinitamurthi
Copy link
Contributor

Merging this!

@vinitamurthi vinitamurthi merged commit 710828b into develop Jan 17, 2022
@vinitamurthi vinitamurthi deleted the disable-cancellation-for-develop-branch branch January 17, 2022 04:20
@BenHenning
Copy link
Sponsor Member Author

Thanks! This should be a nice improvement. I'll keep an eye on submitted PRs to make sure it's working correctly.

bhaktideshmukh pushed a commit to bhaktideshmukh/oppia-android that referenced this pull request Jan 25, 2022
@BenHenning @bhaktideshmukh
Update workflow_canceller.yml (oppia#4043)
807593d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinitamurthi vinitamurthi vinitamurthi approved these changes

@anandwana001 anandwana001 anandwana001 approved these changes

Assignees

@vinitamurthi vinitamurthi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BenHenning @vinitamurthi @anandwana001