Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RunAllTests] Fix #3837 tests end in "Test" #4062

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

rishidyno
Copy link
Contributor

@rishidyno rishidyno commented Dec 16, 2021

Fix #3837

Explanation

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@rishidyno
Copy link
Contributor Author

@BenHenning all tests have passed PTAL.

Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for code owner files.

@BenHenning BenHenning closed this Dec 17, 2021
@BenHenning BenHenning changed the title Fix #3837 tests end in "Test" [RunAllTests] Fix #3837 tests end in "Test" Dec 17, 2021
@BenHenning BenHenning reopened this Dec 17, 2021
@BenHenning
Copy link
Sponsor Member

The PR LGTM, but I needed to restart the CI process to force the new tests to run (given that #4035 is still not fixed). Will approve if CI passes.

Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming both tests ran in CI & passed. Approving & merging. Thanks @rishidyno!

@BenHenning BenHenning merged commit 0fc0d2e into oppia:develop Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure all tests end in "Test"
3 participants