Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable vacation messaging #4079

Merged
merged 2 commits into from
Jan 5, 2022
Merged

Disable vacation messaging #4079

merged 2 commits into from
Jan 5, 2022

Conversation

BenHenning
Copy link
Sponsor Member

@BenHenning BenHenning commented Jan 4, 2022

Explanation

Now that the team is back for reviews, the automated PR message is no longer needed. This PR keeps the messaging support, but disables the vacation-specific message used over the last few weeks.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

N/A -- CI workflow change

@github-actions
Copy link

github-actions bot commented Jan 4, 2022

Thanks for submitting this pull request! Some main reviewers
have taken time off for the next few weeks, so it may take a
little while before we can look at this PR. We appreciate your
patience while some of our team members recharge. We'll be fully
returning on 4 January 2021.

@BenHenning BenHenning marked this pull request as ready for review January 4, 2022 20:31
@BenHenning
Copy link
Sponsor Member Author

@seanlip @rt4914 @anandwana001 PTAL. I'll merge this once I get one approval; just sending it broadly to increase chances of faster turnaround so that this message gets disabled.

Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ben -- left one suggestion, thanks!

@@ -9,6 +9,7 @@ on:
jobs:
holiday_message:
runs-on: ubuntu-latest
if: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps worth adding a comment here saying something like "If situation XXX occurs, do YYY to turn this on." (It doesn't seem obvious to me as a possible future contributor that the natural thing to do is to drop this line altogether.)

Copy link
Sponsor Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion--done.

@seanlip seanlip assigned BenHenning and unassigned seanlip Jan 5, 2022
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, agreed with Sean's comment about adding a comment to make true/false thing more understandable.

@anandwana001 anandwana001 removed their assignment Jan 5, 2022
Add comment per reviewer suggestion.
Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@BenHenning
Copy link
Sponsor Member Author

Thanks @seanlip & @anandwana001. Enabling auto-merge.

@BenHenning BenHenning enabled auto-merge (squash) January 5, 2022 04:19
@BenHenning BenHenning merged commit 37144f1 into develop Jan 5, 2022
@BenHenning BenHenning deleted the disable-vacation-messaging branch January 5, 2022 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants