Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix part of #3602: Added label for MyDownloadsActivity #4103

Merged
merged 4 commits into from
Jan 28, 2022
Merged

Fix part of #3602: Added label for MyDownloadsActivity #4103

merged 4 commits into from
Jan 28, 2022

Conversation

bhaktideshmukh
Copy link
Contributor

@bhaktideshmukh bhaktideshmukh commented Jan 15, 2022 •
edited

Explanation

Fixes #3602 : Added label for MyDownloadsActivity

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@yash10019coder
Copy link
Contributor

Hi @bhaktideshmukh if you are aksing for a review for a PR always add then in the assingee section of the PR , this is how we get to know that we have to review a PR thanks and @rt4914 can you please approve the workflow thanks

yash10019coder
yash10019coder suggested changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@yash10019coder yash10019coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhaktideshmukh add Fixes #4103 in the PR description and @rt4914 please approve the workflow thanks.

app/src/sharedTest/java/org/oppia/android/app/mydownloads/MyDownloadsActivityTest.kt Outdated Show resolved Hide resolved
@oppiabot
Copy link

oppiabot bot commented Jan 18, 2022

Hi @bhaktideshmukh, it looks like some changes were requested on this pull request by @yash10019coder. PTAL. Thanks!

@bhaktideshmukh
Copy link
Contributor Author

PTAL @rt4914 @yash10019coder
Thanks.

@oppiabot oppiabot bot assigned rt4914 and yash10019coder and unassigned bhaktideshmukh Jan 20, 2022
@oppiabot
Copy link

oppiabot bot commented Jan 20, 2022

Unassigning @bhaktideshmukh since a re-review was requested. @bhaktideshmukh, please make sure you have addressed all review comments. Thanks!

rt4914
rt4914 suggested changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhaktideshmukh PTAL thanks.

app/src/sharedTest/java/org/oppia/android/app/mydownloads/MyDownloadsActivityTest.kt Outdated Show resolved Hide resolved
@rt4914 rt4914 assigned bhaktideshmukh and unassigned rt4914 Jan 25, 2022
@bhaktideshmukh
Copy link
Contributor Author

PTAL @rt4914 Thanks.

@oppiabot oppiabot bot assigned rt4914 and unassigned bhaktideshmukh Jan 26, 2022
@oppiabot
Copy link

oppiabot bot commented Jan 26, 2022

Unassigning @bhaktideshmukh since a re-review was requested. @bhaktideshmukh, please make sure you have addressed all review comments. Thanks!

yash10019coder
yash10019coder approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@yash10019coder yash10019coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @bhaktideshmukh thanks

@oppiabot
Copy link

oppiabot bot commented Jan 26, 2022

Unassigning @yash10019coder since they have already approved the PR.

@oppiabot
Copy link

oppiabot bot commented Jan 26, 2022

Assigning @BenHenning, @anandwana001 for code owner reviews. Thanks!

BenHenning
BenHenning requested changes Jan 26, 2022
View reviewed changes
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bhaktideshmukh! Just had a couple of comments--PTAL.

app/src/main/res/values/strings.xml Show resolved Hide resolved
app/src/sharedTest/java/org/oppia/android/app/mydownloads/MyDownloadsActivityTest.kt Show resolved Hide resolved
@bhaktideshmukh
Copy link
Contributor Author

PTAL @BenHenning
Thanks.

@oppiabot oppiabot bot assigned BenHenning and unassigned bhaktideshmukh Jan 27, 2022
@oppiabot
Copy link

oppiabot bot commented Jan 27, 2022

Unassigning @bhaktideshmukh since a re-review was requested. @bhaktideshmukh, please make sure you have addressed all review comments. Thanks!

BenHenning
BenHenning approved these changes Jan 27, 2022
View reviewed changes
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bhaktideshmukh! LGTM for codeowners.

@BenHenning BenHenning removed their assignment Jan 27, 2022
rt4914
rt4914 approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 merged commit e20716b into oppia:develop Jan 28, 2022
@bhaktideshmukh bhaktideshmukh deleted the wip3 branch April 6, 2022 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

@BenHenning BenHenning BenHenning approved these changes

@yash10019coder yash10019coder yash10019coder approved these changes

@anandwana001 anandwana001 Awaiting requested review from anandwana001

Assignees

@rt4914 rt4914

@anandwana001 anandwana001

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[A11y] Add label for all non-test activities
5 participants
@bhaktideshmukh @yash10019coder @rt4914 @BenHenning @anandwana001