Fix patterns for fractions and whitespace normalization #413
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nikitamarysolomanpvt pointed out a few bugs with both fractions and whitespace normalization as part of #376.
See #376 for details around what bugs exist for the fractions patterns & why.
The normalization pattern was a mistake on my part: Regex.fromLiteral() doesn't do what I think it does. Using String's toRegex() is the correct way to do things.
We really should add tests for these. Filed #414 to track this.