Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix patterns for fractions and whitespace normalization #413

Merged
merged 2 commits into from
Nov 20, 2019

Conversation

BenHenning
Copy link
Sponsor Member

@BenHenning BenHenning commented Nov 19, 2019

@nikitamarysolomanpvt pointed out a few bugs with both fractions and whitespace normalization as part of #376.

See #376 for details around what bugs exist for the fractions patterns & why.

The normalization pattern was a mistake on my part: Regex.fromLiteral() doesn't do what I think it does. Using String's toRegex() is the correct way to do things.

We really should add tests for these. Filed #414 to track this.

Update pattern for mixed numbers to require a space between the whole number and fractional term.
Copy link
Contributor

@nikitamarysolomanpvt nikitamarysolomanpvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nikitamarysolomanpvt
Copy link
Contributor

@BenHenning Could you please merge this so that i may create the PR for the test-cases updates.

@BenHenning BenHenning merged commit 4aaee66 into develop Nov 20, 2019
@BenHenning BenHenning deleted the fix-whitespace-and-fractions-patterns branch November 20, 2019 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants