Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input interaction views test-cases fix #453

Merged
merged 32 commits into from
Nov 21, 2019
Merged

Input interaction views test-cases fix #453

merged 32 commits into from
Nov 21, 2019

Conversation

nikitamarysolomanpvt
Copy link
Contributor

@nikitamarysolomanpvt nikitamarysolomanpvt commented Nov 20, 2019 •
edited

Explanation

Input interaction views test-cases updated with data-binding implementation
For testing purpose make following change in code:

  1. Launcher activity should be InputInteractionViewTestActivity

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@nikitamarysolomanpvt
nit
acf2610
@nikitamarysolomanpvt
UI hi-fi for text,number,and fraction input views
b760c44
@nikitamarysolomanpvt
UI hi-fi for text,number,and fraction input views
deaa102
@nikitamarysolomanpvt
UI hi-fi for text,number,and fraction input views nit
5f30564
@nikitamarysolomanpvt
nit
8484f34
@nikitamarysolomanpvt
nit
33e1232
@nikitamarysolomanpvt
test cases update
d108ff0
@nikitamarysolomanpvt
accent color
fc2355f
@nikitamarysolomanpvt
input type in fraction input type
adc0fbf
@nikitamarysolomanpvt
input type in fraction input type
e0a7c5a
@nikitamarysolomanpvt
Merge branches 'develop' and 'hi-fi-input-interaction-views' of https…
47b7aad 
…://github.com/oppia/oppia-android into hi-fi-input-interaction-views

# Conflicts:
#	app/src/main/res/layout/text_input_interaction_item.xml
@nikitamarysolomanpvt
Merge branches 'develop' and 'hi-fi-input-interaction-views' of https…
1e3ed3a 
…://github.com/oppia/oppia-android into hi-fi-input-interaction-views

# Conflicts:
#	app/src/main/res/layout/text_input_interaction_item.xml
@nikitamarysolomanpvt
text color in input type views
fe0f1d8
@nikitamarysolomanpvt
changed inputtype in edit text
8a489a0
@nikitamarysolomanpvt
margin updated in input views
0eff2ef
@nikitamarysolomanpvt
margin updated in input views
9d8f704
@nikitamarysolomanpvt
nit
b429ec8
@nikitamarysolomanpvt
keyboardhelper to handle softinoutkeyboard
9981d81
@nikitamarysolomanpvt
Merge branch 'develop' of https://github.com/oppia/oppia-android into…
321facd 
… hi-fi-input-interaction-views
@nikitamarysolomanpvt
Edit text focus removed.
ef864b2 
On click of input type interaction item, it requires two clicks to display keyboard, which should actually be just a single click.
thus preventing scroll due to edit text focus
@nikitamarysolomanpvt
as per review suggestion added binding.stateRecyclerView.smoothScroll…
70d4c73 
…ToPosition(0) in processEphemeralStateResult
@nikitamarysolomanpvt
nit
6d01b40
Fix-406
8289c5e
@nikitamarysolomanpvt
nit changes and keybord helper class renamed.
900d248
@nikitamarysolomanpvt
Merge branches 'fix-406' and 'hi-fi-input-interaction-views' of https…
4c6a0db 
…://github.com/oppia/oppia-android into hi-fi-input-interaction-views
@nikitamarysolomanpvt
nit
1c94120
@nikitamarysolomanpvt
merged with develop, inputviews test cases fix
8e88592
@nikitamarysolomanpvt
merged with develop, inputviews test cases fix
cab8a46
@nikitamarysolomanpvt
merged with develop, inputviews test cases fix
3205271
@nikitamarysolomanpvt
Merge branch 'develop' of https://github.com/oppia/oppia-android into…
98185cf 
… topic-multiple-choice-focus-issue-fix

# Conflicts:
#	app/src/main/res/layout/selection_interaction_item.xml
@nikitamarysolomanpvt
Copy link
Contributor Author

@BenHenning waiting for #413 getting merged.

veena14cs
veena14cs approved these changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@veena14cs veena14cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

rt4914
rt4914 approved these changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rt4914 rt4914 merged commit dfbd4ba into develop Nov 21, 2019
@rt4914 rt4914 deleted the input-interaction-views-testcases-fix branch November 21, 2019 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

@veena14cs veena14cs veena14cs approved these changes

Assignees

@nikitamarysolomanpvt nikitamarysolomanpvt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nikitamarysolomanpvt @rt4914 @veena14cs @jamesxu0