Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4017: Radio Button Implementation #4225

Merged
merged 8 commits into from
Mar 10, 2022
Merged

Conversation

anandwana001
Copy link
Contributor

@anandwana001 anandwana001 commented Feb 28, 2022

Explanation

Fix #4017
Earlier, the MCQ questions which can accept only 1 answer do not contain the submit button and worked on the concept of direct selection to check if the answer is correct or not. (Selection is the submission)
But, for the questions which can accept more than 1 answer do have a submit answer button.

This PR makes the submit button available for former questions also which can accept only 1 answer.

Testing

I had added a few tests which test the single selection (Radio buttons) in multiple conditions.
I had tested espresso tests, for robolectric, I am relying on GitHub actions.

UI Related Items

Before

After

All the newly added tests passing on espresso.
Screenshot 2022-03-03 at 17 06 42

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@anandwana001
Copy link
Contributor Author

Once all tests in action pass, I will add the UI-related stuff in the PR description.

@anandwana001 anandwana001 assigned rt4914 and BenHenning and unassigned anandwana001 Mar 3, 2022
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anandwana001! I think this looks really good. Just had a few comments--PTAL.

@BenHenning BenHenning assigned anandwana001 and unassigned BenHenning Mar 4, 2022
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @anandwana001

@rt4914 rt4914 removed their assignment Mar 7, 2022
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anandwana001. Just had two nits, otherwise the PR LGTM.

@BenHenning BenHenning assigned anandwana001 and unassigned BenHenning Mar 8, 2022
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anandwana001. LGTM!

@BenHenning
Copy link
Sponsor Member

Merging since it seems all approvals have been met, and no remaining conversations require resolution.

@BenHenning BenHenning merged commit 3a0d4e5 into develop Mar 10, 2022
@BenHenning BenHenning deleted the radio-button-impl branch March 10, 2022 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Radio Button Implementation
3 participants