Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localisation updates from https://translatewiki.net. #4279

Merged
merged 1 commit into from
Apr 15, 2022
Merged

Localisation updates from https://translatewiki.net. #4279

merged 1 commit into from
Apr 15, 2022

Conversation

translatewiki
Copy link
Member

Translation updates

@translatewiki translatewiki force-pushed the translatewiki-prs branch 3 times, most recently from 99b6941 to 6b69298 Compare April 7, 2022 11:10
@BenHenning BenHenning self-assigned this Apr 12, 2022
@BenHenning
Copy link
Sponsor Member

The strings look good, but I need to double check the FAQ (& general app layout) to make sure string interpolation is working correctly, and that the little bit of embedded HTML wasn't mangled.

@BenHenning
Copy link
Sponsor Member

Other than the unrelated Gradle CI failure & some missing strings, the translations seem to be working. They're generally longer than other languages, so they're revealing some sizing issues throughout the app but they should be sufficient for the upcoming study.

We may need to consider specifying character limits in the future, as well, if that's an option.

@BenHenning BenHenning enabled auto-merge (squash) April 15, 2022 13:24
@oppiabot
Copy link

oppiabot bot commented Apr 15, 2022

Unassigning @BenHenning since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label Apr 15, 2022
@oppiabot
Copy link

oppiabot bot commented Apr 15, 2022

Hi @translatewiki, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!

BenHenning added a commit that referenced this pull request Apr 15, 2022
@BenHenning
Add support for Swahili (Kenya).
ac25d99 
The initial translations are being introduced in #4279 and the asset
pipeline has already been updated.
@BenHenning BenHenning mentioned this pull request Apr 15, 2022
Merged
6 tasks
@BenHenning BenHenning merged commit ba72b17 into develop Apr 15, 2022
BenHenning added a commit that referenced this pull request May 6, 2022
@BenHenning
Fix #4305: Add support for Swahili translations (app strings and cont…
c73c768 
…ent) (#4307)

* Add support for Swahili (Kenya).

The initial translations are being introduced in #4279 and the asset
pipeline has already been updated.

* Fix broken tests due to new language & region.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenHenning BenHenning BenHenning approved these changes

Assignees

@translatewiki translatewiki

Labels
PR: LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@translatewiki @BenHenning