Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4305: Add support for Swahili translations (app strings and content) #4307

Merged
merged 4 commits into from
May 6, 2022

Conversation

BenHenning
Copy link
Sponsor Member

@BenHenning BenHenning commented Apr 15, 2022

Explanation

Fixes #4305

This PR introduces the base support for Swahili content and audio voiceover translations, and also registers Kenya as an accepted region by the app. #4279 is introducing the initial batch of app string translations, and the content pipeline has been updated to support importing Swahili translations. See the screenshot below for a reference.

Note that there aren't really any tests to add besides the manual verification.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

This PR is changing exactly one UI surface: support for Swahili. See this screenshot for reference:
image

Note that Swahili has exposed a few text overflow situations in the app but these are acceptable in the current alpha state of the app.

The initial translations are being introduced in #4279 and the asset
pipeline has already been updated.
@BenHenning BenHenning marked this pull request as ready for review April 15, 2022 13:32
@BenHenning
Copy link
Sponsor Member Author

BenHenning commented Apr 15, 2022

Hi @anandwana001. PTAL at the whole PR as I plan to defer @vinitamurthi's review.

Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

Waiting for all the checks to pass.

@oppiabot
Copy link

oppiabot bot commented Apr 18, 2022

Unassigning @anandwana001 since the review is done.

@oppiabot
Copy link

oppiabot bot commented Apr 18, 2022

Hi @BenHenning, it looks like some changes were requested on this pull request by @anandwana001. PTAL. Thanks!

@oppiabot
Copy link

oppiabot bot commented Apr 25, 2022

Hi @BenHenning, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Apr 25, 2022
@oppiabot oppiabot bot closed this May 2, 2022
@BenHenning BenHenning reopened this May 2, 2022
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label May 2, 2022
@BenHenning BenHenning changed the title Fix #4305: Add support for Swahili translations (app, content, and audio) Fix #4305: Add support for Swahili translations (app, and content) May 5, 2022
@BenHenning BenHenning changed the title Fix #4305: Add support for Swahili translations (app, and content) Fix #4305: Add support for Swahili translations (app strings and content) May 5, 2022
@BenHenning
Copy link
Sponsor Member Author

BenHenning commented May 5, 2022

TODO: Update opening comment to explain that this doesn't introduce support for audio translations & why, and how it also includes pulling in titles & descriptions from Oppia web for other languages (as part of #4306).

Edit: The above is no longer true per the current plan.

@BenHenning BenHenning requested a review from rt4914 as a code owner May 6, 2022 07:26
@BenHenning
Copy link
Sponsor Member Author

Note that any additional changes needed in this PR will be covered in #4345 as a fast-follow.

Furthermore, @anandwana001's and @rt4914's reviews are being deferred (#4344 and #4266 are tracking each, respectively). Note that this does result in no approvals, but I've gotten confirmation from @seanlip as another technical representative that this is reasonable given the circumstances of getting these changes in quickly for an upcoming release. I'll make sure this PR does get reviewed post-submission.

@BenHenning BenHenning merged commit c73c768 into develop May 6, 2022
@BenHenning BenHenning deleted the add-swahili-support branch May 6, 2022 08:45
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Swahili translations
4 participants