Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4513 : Dark mode implementation - Dialogs, Status Bar #4811

Merged
merged 57 commits into from
Dec 29, 2022
Merged

Fixes #4513 : Dark mode implementation - Dialogs, Status Bar #4811

merged 57 commits into from
Dec 29, 2022

Conversation

MohitGupta121
Copy link
Member

@MohitGupta121 MohitGupta121 commented Dec 28, 2022

Explanation

Fixes #4513 : Dark mode implementation - Dialogs, Status Bar

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

Cellular Data Dialog

Bottom Sheet Options Menu

Profile Picture Edit Dialog

Reveal Solution Dialog

Full Screen Dialogs

Concept Card Dialog

Hint and Solutions Dialog

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@MohitGupta121 MohitGupta121 self-assigned this Dec 28, 2022
@github-actions
Copy link

Thanks for submitting this pull request! Some main reviewers
have taken time off for the next few weeks, so it may take a
little while before we can look at this PR. We appreciate your
patience while some of our team members recharge. We'll be fully
returning on 10 January 2022.

Copy link
Member Author

@MohitGupta121 MohitGupta121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rt4914 Can you PTAL on this PR.

@MohitGupta121 MohitGupta121 changed the title Dark mode implementation - Dialogs, Status Bar Fixes #4513 : Dark mode implementation - Dialogs, Status Bar Dec 28, 2022
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Suggested minor fixes.

@rt4914 rt4914 assigned MohitGupta121 and unassigned rt4914 Dec 29, 2022
@oppiabot oppiabot bot added the PR: LGTM label Dec 29, 2022
@MohitGupta121
Copy link
Member Author

MohitGupta121 commented Dec 29, 2022

@rt4914 Done the review changes. PTAL.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Dark Mode support for BottomSheetFragment (Exploration + Revision Card)
2 participants