Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4513 : Dark mode implementation - BottomSheetFragment (Exploration + Revision Card) #4812

Merged
merged 55 commits into from
Dec 29, 2022
Merged

Fixes #4513 : Dark mode implementation - BottomSheetFragment (Exploration + Revision Card) #4812

merged 55 commits into from
Dec 29, 2022

Conversation

MohitGupta121
Copy link
Member

Explanation

Fixes #4513 : Dark mode implementation - BottomSheetFragment (Exploration + Revision Card)

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

Bottom Sheet Options Menu

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@github-actions
Copy link

Thanks for submitting this pull request! Some main reviewers
have taken time off for the next few weeks, so it may take a
little while before we can look at this PR. We appreciate your
patience while some of our team members recharge. We'll be fully
returning on 10 January 2022.

@MohitGupta121
Copy link
Member Author

@rt4914 PTAL.
I raised this PR due to this comment as I already I implemented the Dark Mode for Bottom Sheet Options menu in PR #4811

Thanks.

@rt4914 rt4914 enabled auto-merge (squash) December 29, 2022 13:40
@oppiabot oppiabot bot unassigned rt4914 Dec 29, 2022
@oppiabot
Copy link

oppiabot bot commented Dec 29, 2022

Unassigning @rt4914 since they have already approved the PR.

@rt4914 rt4914 merged commit fdd9ec8 into oppia:develop Dec 29, 2022
@MohitGupta121 MohitGupta121 deleted the DarkMode-BottomSheetFragment branch December 29, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Dark Mode support for BottomSheetFragment (Exploration + Revision Card)
2 participants