Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit all xml layout files for Dark Mode audit #4954

Merged
merged 5 commits into from
Apr 25, 2023
Merged

Revisit all xml layout files for Dark Mode audit #4954

merged 5 commits into from
Apr 25, 2023

Conversation

MohitGupta121
Copy link
Member

@MohitGupta121 MohitGupta121 commented Apr 21, 2023

Explanation

Revisit all xml layout files for Dark Mode audit:

  • Rearrange code in layout files
  • Prohibited use of hex color in xml layouts file - added regex check

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

Copy link
Member Author

@MohitGupta121 MohitGupta121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BenHenning PTAL, Thanks.
Can I add screenshot for any screen?
As I not change any thing from color side, except to move Hex color of splash activity to component color.

Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MohitGupta121. This looks good! I always appreciate a good clean-up. :) Thanks also for adding the extra regex check.

@BenHenning
Copy link
Sponsor Member

@BenHenning PTAL, Thanks. Can I add screenshot for any screen? As I not change any thing from color side, except to move Hex color of splash activity to component color.

@MohitGupta121 given that this is just a simple refactor with no side-effects, a screenshot isn't really needed here.

@BenHenning
Copy link
Sponsor Member

Updating PR to latest develop & enabling auto-merge.

@BenHenning BenHenning enabled auto-merge (squash) April 25, 2023 03:52
@MohitGupta121
Copy link
Member Author

Thanks @BenHenning

@oppiabot
Copy link

oppiabot bot commented Apr 25, 2023

Unassigning @BenHenning since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label Apr 25, 2023
@oppiabot
Copy link

oppiabot bot commented Apr 25, 2023

Hi @MohitGupta121, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!

@BenHenning BenHenning merged commit 41f80bc into oppia:develop Apr 25, 2023
37 checks passed
@MohitGupta121 MohitGupta121 deleted the revisit_all_xml_dark_mode branch April 25, 2023 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants