Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit all xml drawables files for Dark Mode audit #4960

Merged
merged 2 commits into from
May 4, 2023
Merged

Revisit all xml drawables files for Dark Mode audit #4960

merged 2 commits into from
May 4, 2023

Conversation

MohitGupta121
Copy link
Member

@MohitGupta121 MohitGupta121 commented Apr 28, 2023

Explanation

Revisit all xml drawables files for Dark Mode audit:

  • Prohibited use of color other than component_colors in xml drawables file except vector assets, graphics- added regex check
  • Remove unused Drawables files

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

Copy link
Member Author

@MohitGupta121 MohitGupta121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BenHenning PTAL, Thanks.

As I talk to Rajat in chat and he said we only keep use of component_color in all xml files (include drawables, layouts) but except images, graphics, icons, vector assets and also add regex for all xml.

So in this PR I do all these things, and added separate regex check for drawables and layout. Is it fine?

@BenHenning
Copy link
Sponsor Member

Apologies @MohitGupta121 will need to look at this tomorrow.

@MohitGupta121
Copy link
Member Author

@BenHenning no problem totally fine.

Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MohitGupta121. This LGTM!

@BenHenning BenHenning enabled auto-merge (squash) May 4, 2023 01:28
@oppiabot
Copy link

oppiabot bot commented May 4, 2023

Unassigning @BenHenning since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label May 4, 2023
@oppiabot
Copy link

oppiabot bot commented May 4, 2023

Hi @MohitGupta121, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants