Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links text while dark mode audit #5000

Merged
merged 1 commit into from
May 31, 2023
Merged

Fix links text while dark mode audit #5000

merged 1 commit into from
May 31, 2023

Conversation

MohitGupta121
Copy link
Member

@MohitGupta121 MohitGupta121 commented May 29, 2023

Explanation

Fixed some links text while dark mode audit

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

Hints & Solution

Before - Light Mode Before - Dark Mode
After - Light Mode After - Dark Mode

Onboarding Screen

Before - Light Mode Before - Dark Mode
After - Light Mode After - Dark Mode

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

Copy link
Member Author

@MohitGupta121 MohitGupta121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BenHenning PTAL, make some audit changes while A11Y Scanner. Thanks!

@MohitGupta121 MohitGupta121 changed the title Fixed some links text while dark mode audit Fix links text while dark mode audit May 29, 2023
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MohitGupta121 and nice catch! LGTM.

(Also, nice PR number (: ).

@BenHenning BenHenning merged commit ef01e73 into develop May 31, 2023
37 checks passed
@BenHenning BenHenning deleted the darkmode_audit branch May 31, 2023 07:55
@MohitGupta121
Copy link
Member Author

Thanks @BenHenning.
Also I updated A11Y scanner video for dark-mode in this

Is we need to make similar for Talkback?

@BenHenning
Copy link
Sponsor Member

Thanks @BenHenning. Also I updated A11Y scanner video for dark-mode in this

Is we need to make similar for Talkback?

I don't think one for Talkback is necessary since Talkback shouldn't change behavior due to colors, only due to navigational or textual changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants