Param specified everywhere, bool value now inline html

oppia · Apr 12, 2024 · 5330042 · 5330042
1 parent 827c903
commit 5330042
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/core/templates/components/question-directives/questions-list/questions-list.component.html b/core/templates/components/question-directives/questions-list/questions-list.component.html
@@ -43,7 +43,8 @@ <h4> <strong> Linked Skills </strong> </h4>
                            [misconceptionsBySkill]="misconceptionsBySkill"
                            [questionStateData]="questionStateData"
                            [question]="question"
-                           [userCanEditQuestion]="canEditQuestion">
+                           [userCanEditQuestion]="canEditQuestion"
+                           [stateContentShouldStayVisibleOnScroll]="false">
     </oppia-question-editor>
     <div class="alert alert-danger" *ngIf="question.getStateData().interaction.id && questionValidationService.getValidationErrorMessage(question)">
       {{questionValidationService.getValidationErrorMessage(question)}}

diff --git a/...ontributor-dashboard-page/modal-templates/question-suggestion-editor-modal.component.html b/...ontributor-dashboard-page/modal-templates/question-suggestion-editor-modal.component.html
@@ -33,7 +33,8 @@ <h3>Your Practice Question</h3>
                              [misconceptionsBySkill]="misconceptionsBySkill"
                              [questionStateData]="questionStateData"
                              [question]="question"
-                             [userCanEditQuestion]="canEditQuestion">
+                             [userCanEditQuestion]="canEditQuestion"
+                             [stateContentShouldStayVisibleOnScroll]="false">
       </oppia-question-editor>
     </div>
     <div class="alert alert-danger" *ngIf="question.getStateData().interaction.id && getQuestionValidationErrorMessage()">

diff --git a/.../contributor-dashboard-page/modal-templates/question-suggestion-review-modal.component.ts b/.../contributor-dashboard-page/modal-templates/question-suggestion-review-modal.component.ts
@@ -142,7 +142,6 @@ export class QuestionSuggestionReviewModalComponent
   questionId: string | null = null;
   isFirstItem: boolean = true;
   isLastItem: boolean = true;
-  stateContentShouldStayVisibleOnScroll: boolean = true;
 
   constructor(
     private contextService: ContextService,

diff --git a/...ages/contributor-dashboard-page/modal-templates/question-suggestion-review.component.html b/...ages/contributor-dashboard-page/modal-templates/question-suggestion-review.component.html
@@ -41,11 +41,11 @@ <h3 class="oppia-mobile-question-header" title="{{questionHeader}}">
     </div>
     <div *ngIf="showQuestion">
       <oppia-question-editor [questionId]="questionId"
-                             [stateContentShouldStayVisibleOnScroll]="stateContentShouldStayVisibleOnScroll"
                              [misconceptionsBySkill]="misconceptionsBySkill"
                              [questionStateData]="questionStateData"
                              [question]="question"
                              [userCanEditQuestion]="canEditQuestion"
+                             [stateContentShouldStayVisibleOnScroll]="true"
                              (questionChange)="questionChanged()"
                              tabindex="0">
       </oppia-question-editor>