Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Contributor Dashboard] Add inline translation tips to translation cards. #12180

Closed
sagangwee opened this issue Mar 12, 2021 · 8 comments · Fixed by #12339
Closed

[Contributor Dashboard] Add inline translation tips to translation cards. #12180

sagangwee opened this issue Mar 12, 2021 · 8 comments · Fixed by #12339
Assignees
@jimbyo

Comments

@sagangwee
Copy link
Contributor

In addition to updating user translation guides, we want to make sure we remind translators of best practices for translations directly in the translation card below the content text, e.g. recommending certain tones when translating Hindi.
@sagangwee
Copy link
Contributor Author

@seanlip You had some ideas on how to implement this?

@seanlip
Copy link
Member

seanlip commented Mar 12, 2021

Yup. For now let's just have a constants dict that maps from language codes into a list of strings. Each list item is displayed as a bullet point. Ideally just plaintext, no html.

We then only display tips if the language code's key exists in the dict.

Sg?

@sagangwee sagangwee moved this from P1 to High Priority User Feedback Requests in Contributor Experience Mar 12, 2021
@sagangwee
Copy link
Contributor Author

Sounds good, thanks!

@sagangwee sagangwee moved this from High Priority User Feedback Requests to Critical User Bugs in Contributor Experience Mar 16, 2021
@sagangwee sagangwee moved this from Critical User Bugs to April Release in Contributor Experience Mar 17, 2021
@sagangwee
Copy link
Contributor Author

@seanlip Is there a running list somewhere of translation tips we want to initially seed this feature with?

@seanlip
Copy link
Member

seanlip commented Mar 17, 2021

Hm -- could you please get these from Anu? I can help with wordsmithing but I think she would be the main source of information on this one.

Thanks!

@sagangwee
Copy link
Contributor Author

PR: #12339

@sagangwee sagangwee mentioned this issue Mar 29, 2021
Merged
4 tasks
@jimbyo jimbyo linked a pull request Mar 29, 2021 that will close this issue
Fix #12180 Add inline translation tips to translation cards. #12339
Merged
4 tasks
nithusha21 pushed a commit that referenced this issue Apr 3, 2021
@jimbyo
Fix #12180 Add inline translation tips to translation cards. (#12339)
ecf60ce 
* Add translation tips

* Move translation tips below rte editor and add grey background

* move background-color before border in css

* resolve comments

* fix lints

* fix lints

* fix lints

* fix lints

* reorder imports
@sagangwee
Copy link
Contributor Author

Additional tips to be added here.

@sagangwee sagangwee reopened this Jun 1, 2021
@sagangwee sagangwee added this to 2021-06-04 Release Cut in Contributor Experience Jun 1, 2021
@sagangwee sagangwee mentioned this issue Jun 1, 2021
Closed
@sagangwee
Copy link
Contributor Author

Tracking new tips here: #12960

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jimbyo jimbyo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #12180 Add inline translation tips to translation cards. jimbyo/oppia
3 participants
@sagangwee @seanlip @jimbyo