Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audio Bar can be fixed or synced with Top-navigation-bar #12575

Closed
mridul-netizen opened this issue Apr 21, 2021 · 3 comments · Fixed by #12702
Closed

Audio Bar can be fixed or synced with Top-navigation-bar #12575

mridul-netizen opened this issue Apr 21, 2021 · 3 comments · Fixed by #12702
Assignees
@Rijuta-s

Comments

@mridul-netizen
Copy link
Contributor

Describe the bug
Audio Bar is not fixed with Top-navigation-bar

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://oppiatestserver.appspot.com/
    2.See the Audio bar in mobile view

Smartphone (please complete the following information; delete this section if the issue does not arise on smartphones):
-All displays

Additional context
Add any other context about the problem here.

mobile_view_audio_bar.mp4
@mridul-netizen mridul-netizen added this to the Blocking bugs milestone Apr 21, 2021
@U8NWXD
Copy link
Member

U8NWXD commented Apr 22, 2021

@kevintab95 @aks681 since this bug is in the learner experience, could you either take it up or delegate it to someone else in the LACE team?

@U8NWXD
Copy link
Member

U8NWXD commented Apr 28, 2021

@aks681 when can you fix this bug? It's blocking the release, so please prioritize it

@kevintab95 kevintab95 assigned Rijuta-s and unassigned aks681 May 1, 2021
@kevintab95
Copy link
Member

@Rijuta-s FYI I've assigned you per offline discussion!

@Rijuta-s Rijuta-s mentioned this issue May 1, 2021
Merged
4 tasks
@U8NWXD U8NWXD linked a pull request May 3, 2021 that will close this issue
Fixes #12575 : Fixes audio bar position on small screens. #12702
Merged
4 tasks
@U8NWXD U8NWXD modified the milestones: Blocking Bugs for Current Release, Blocking Bugs for Next Release May 5, 2021
Rijuta-s added a commit that referenced this issue May 5, 2021
@Rijuta-s
Fixes #12575 : Fixes audio bar position on small screens. (#12702)
86d6308 
* fixing audio navbar

* minor fix

* Merge branch 'audio-navbar' of https://github.com/Rijuta-s/oppia into audio-navbar

* fixing lint issues

* fixing minor issue

* Update audio-bar.directive.html

* syncing audio bar with navbar

* syncing audio-bar with navbar

* minor fix
aks681 pushed a commit that referenced this issue May 14, 2021
@Rijuta-s @aks681
Fixes #12575 : Fixes audio bar position on small screens. (#12702)
09a2225 
* fixing audio navbar

* minor fix

* Merge branch 'audio-navbar' of https://github.com/Rijuta-s/oppia into audio-navbar

* fixing lint issues

* fixing minor issue

* Update audio-bar.directive.html

* syncing audio bar with navbar

* syncing audio-bar with navbar

* minor fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rijuta-s Rijuta-s

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #12575 : Fixes audio bar position on small screens. Rijuta-s/oppia
5 participants
@kevintab95 @U8NWXD @aks681 @mridul-netizen @Rijuta-s