[FE Flake]: Contributor dashboard page Expected 'Topic 1' to be undefined.

[gp201]

Stacktrace

Chrome Headless 107.0.5304.87 (Linux x86_64) Contributor dashboard page when user is logged in should not set active topic name when no topics are returned FAILED
	Error: Expected 'Topic 1' to be undefined.
	    at <Jasmine>
	    at UserContext.<anonymous> (core/templates/combined-tests.spec.js:98615:41)
	    at UserContext.<anonymous> (core/templates/combined-tests.spec.js:720401:34)
	    at ./node_modules/zone.js/dist/zone.js.ZoneDelegate.invoke (core/templates/combined-tests.spec.js:721630:30)
	Error: Expected spy setActiveTopicName not to have been called.
	    at <Jasmine>
	    at UserContext.<anonymous> (core/templates/combined-tests.spec.js:98617:22)
	    at UserContext.<anonymous> (core/templates/combined-tests.spec.js:720401:34)
	    at ./node_modules/zone.js/dist/zone.js.ZoneDelegate.invoke (core/templates/combined-tests.spec.js:721630:30)

This seems to have been caused due to the spy getting defined twice.

once in the beforeEach

oppia/core/templates/pages/contributor-dashboard-page/contributor-dashboard-page.component.spec.ts

Lines 83 to 86 in 7b5841e

	getTranslatableTopicNamesAsyncSpy = spyOn(
	contributionOpportunitiesService, 'getTranslatableTopicNamesAsync');
	getTranslatableTopicNamesAsyncSpy.and.returnValue(
	Promise.resolve(['Topic 1', 'Topic 2']));

again in the test:

oppia/core/templates/pages/contributor-dashboard-page/contributor-dashboard-page.component.spec.ts

Lines 164 to 165 in 7b5841e

	getTranslatableTopicNamesAsyncSpy.and.returnValue(
	Promise.resolve([]));

Additional Information

Seeds:

1. 419

Complete Log

• https://github.com/oppia/oppia/actions/runs/3448487413/jobs/5755552970#step:9:2478
• https://github.com/oppia/oppia/actions/runs/3612331567/jobs/6087366397#step:9:6779

Debug Doc

[gp201]

@sagangwee This flake seems to have been introduced via #15841 Can you please open a fix for this?

You solve this by either splitting the tests using a nested describe function where getTranslatableTopicNamesAsyncSpy returns a topics in one and in the other it returns an empty list or define the spy for each test explicitly.

[gp201]

@heyimShivam Should ngOnInit be called before every test?

oppia/core/templates/pages/contributor-dashboard-page/contributor-dashboard-page.component.spec.ts

Line 108 in 7b5841e

component.ngOnInit();

Since ngOnInit is called inside tests again.

[sagangwee]

@gp201 Hmmm I would have expected the existing code to override the currently set return value on the spy. Does the flake have something to do with the fakeAsync wrapper?

[U8NWXD]

Closing because this flake did not appear in 120 consecutive runs on develop:

• 40 runs: https://github.com/oppia/oppia/actions/runs/4271360644
• 40 runs: https://github.com/oppia/oppia/actions/runs/4270924251
• 40 runs: https://github.com/oppia/oppia/actions/runs/4270696107

[gp201]

Reappeared in develop once on 10 March 2023; commit number: e86d2a3

GitHub Action run
https://github.com/oppia/oppia/actions/runs/4377536374
log.zip

[gp201]

30th May 2023 https://github.com/oppia/oppia/actions/runs/5098191142/jobs/9165188421

[462702985]

20th Jun 2023 https://github.com/oppia/oppia/actions/runs/5326006053/jobs/9647613822
01 July 2023 https://github.com/oppia/oppia/actions/runs/5430868988/jobs/9876961240